| Age | Commit message (Collapse) | Author |
|
Preparation was in CL 134570043.
This CL contains only the effect of 'hg mv src/pkg/* src'.
For more about the move, see golang.org/s/go14nopkg.
|
|
Fixes #8145.
LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/126440043
|
|
LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/122910043
|
|
Fixes #5750.
https://code.google.com/p/go/issues/detail?id=5750
os: Separate windows from posix. Implement windows support.
path/filepath: Use the same implementation as other platforms
syscall: Add/rework new APIs for Windows
LGTM=alex.brainman
R=golang-codereviews, alex.brainman, gobot, rsc, minux
CC=golang-codereviews
https://golang.org/cl/86160044
|
|
Add nacl.bash, the NaCl version of all.bash.
It's a separate script because it builds a variant of package syscall
with a large zip file embedded in it, containing all the input files
needed for tests.
Disable various tests new since the last round, mostly the ones using os/exec.
Fixes #7945.
LGTM=dave
R=golang-codereviews, remyoudompheng, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/100590044
|
|
os: don't ignore LStat errors in Readdir. If it's ENOENT,
on the second pass, just treat it as missing. If it's another
error, it's real.
path/filepath: use ReaddirNames instead of Readdir in Walk,
in order to obey the documented WalkFunc contract of returning
each walked item's LStat error, if any.
Fixes #6656
Fixes #6680
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/43530043
|
|
Bug3486 tried to walk the entire file tree, but other tests might
be creating and removing files in that tree. In particular, package os
creates and removes files in the os directory, and issue 5863
reports failures due to seeing those files appear and then disappear.
Change the test to walk just the test tree, which should not be
changing.
Fixes #5863.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13467045
|
|
Update #5000
Should reduce the flakiness a little. Malloc counting is important
to general testing but not to the build dashboard, which uses -short.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/12866047
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9713044
|
|
Fixes #4974.
R=rsc, bradfitz, r
CC=golang-dev
https://golang.org/cl/7545043
|
|
On Windows, directory names in PATH can be fully or partially quoted
in double quotes ('"'), but the path names as used by most APIs must
be unquoted. In addition, quoted names can contain the semicolon
(';') character, which is otherwise used as ListSeparator.
This CL changes SplitList in path/filepath and LookPath in os/exec
to only treat unquoted semicolons as separators, and to unquote the
separated elements.
(In addition, fix harmless test bug I introduced for LookPath on Unix.)
Related discussion thread:
https://groups.google.com/d/msg/golang-nuts/PXCr10DsRb4/sawZBM7scYgJ
R=rsc, minux.ma, mccoyst, alex.brainman, iant
CC=golang-dev
https://golang.org/cl/7181047
|
|
This CL also replaces similar loops in other stdlib
package tests with calls to AllocsPerRun.
Fixes #4461.
R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/7002055
|
|
also fix an annoying test that relies on $GOROOT be set.
Fixes #3690.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6844086
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6350047
|
|
Alternative to https://golang.org/cl/6330044.
Fixes #3681.
R=golang-dev, r, hanwen, iant
CC=golang-dev
https://golang.org/cl/6335056
|
|
Make it possible to run test over symlinked GOROOT.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6268046
|
|
Currently walk() doesn't check for err == SkipDir when iterating
a directory list, but such promise is made in the docs for WalkFunc.
Fixes #3486.
R=rsc, r
CC=golang-dev
https://golang.org/cl/6257059
|
|
Fixes #3476.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5986045
|
|
Fixes #3347.
R=golang-dev, aram, r, rsc
CC=golang-dev
https://golang.org/cl/5918043
|
|
R=golang-dev, r
CC=golang-dev, mattn.jp
https://golang.org/cl/5885056
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5781058
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5756049
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5756064
|
|
SameFile has a bug.
R=golang-dev
TBR=rsc
CC=golang-dev
https://golang.org/cl/5754055
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5759051
|
|
/tmp being itself a symlink causes problems for the test, so use / as the absolute path.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5675070
|
|
Fixes #2950.
Fixes #2951.
R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/5672044
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5645099
|
|
I hate symlinks.
Fixes #2787.
R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5638043
|
|
TBR=golang-dev
CC=golang-dev
https://golang.org/cl/5625050
|
|
This reduces the overhead necessary to work with OS-specific
file details, hides the implementation of FileStat, and
preserves the implementation-specific nature of Sys.
Expressions such as:
stat.(*os.FileInfo).Sys.(*syscall.Stat_t).Uid
fi1.(*os.FileStat).SameFile(fi2.(*os.FileStat))
Are now spelled as::
stat.Sys().(*syscall.Stat_t).Uid
os.SameFile(fi1, fi2)
R=cw, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5448079
|
|
Consequently, remove many package Makefiles,
and shorten the few that remain.
gomake becomes 'go tool make'.
Turn off test phases of run.bash that do not work,
flagged with $BROKEN. Future CLs will restore these,
but this seemed like a big enough CL already.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5601057
|
|
If there's an error, sometimes you need to stop.
Part of issue 2787.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5570068
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5501069
|
|
There was Base but not Dir, so fill in the gap.
R=n13m3y3r, r, rsc, gustavo
CC=golang-dev
https://golang.org/cl/5503067
|
|
R=golang-dev, bradfitz, gri
CC=golang-dev
https://golang.org/cl/5451079
|
|
R=golang-dev, r, r, gri, bradfitz, iant, iant, nigeltao, n13m3y3r
CC=golang-dev
https://golang.org/cl/5416060
|
|
Fixes #2493.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5433079
|
|
R=golang-dev, bsiegert, iant
CC=golang-dev
https://golang.org/cl/5294074
|
|
R=golang-dev, rsc, gustavo, r, borman
CC=golang-dev
https://golang.org/cl/4981049
|
|
This one uses a closure than an interface, and is much simpler to use.
It also enables a called function to return an error and (possibly)
halt processing.
Fixes #2237.
R=golang-dev, gri, rsc, r, cw, n13m3y3r
CC=golang-dev
https://golang.org/cl/5014043
|
|
Fixes #2201
R=golang-dev, r, rsc, alex.brainman, robert.hencke, jp
CC=golang-dev
https://golang.org/cl/4950051
|
|
API change. Needs further reflection.
««« original CL description
path/filepath: Simplify Walk interface
The last argument of filepath.Walk was removed, and the Visitor
interface now contains an Error method that is called on errors.
Fixes #2237.
R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/4964067
»»»
R=r
CC=golang-dev
https://golang.org/cl/4974065
|
|
The last argument of filepath.Walk was removed, and the Visitor
interface now contains an Error method that is called on errors.
Fixes #2237.
R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/4964067
|
|
R=r
CC=golang-dev
https://golang.org/cl/4984052
|
|
- Clean and IsAbs to handle paths with drive letter properly.
- Clean to replace / with \.
R=golang-dev, adg
CC=golang-dev, mattn.jp
https://golang.org/cl/4758051
|
|
R=golang-dev
CC=golang-dev
https://golang.org/cl/4630066
|
|
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4517132
|
|
When I was first coding Abs, I wondered if people wouldn't
expect the path to be consistently clean, even if the path
passed in was already absolute.
CL 4524078 has a potential problem based on exactly that
assumption, so it feels like this behavior is indeed the
most useful and least surprising.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4548074
|
|
Fixes #1830.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4526060
|