| Age | Commit message (Collapse) | Author |
|
Preparation was in CL 134570043.
This CL contains only the effect of 'hg mv src/pkg/* src'.
For more about the move, see golang.org/s/go14nopkg.
|
|
Fixes #8503.
Thanks to no.smile.face for the original report.
LGTM=bradfitz, r, ruiu
R=bradfitz, ruiu, r
CC=golang-codereviews
https://golang.org/cl/132730043
|
|
Fixes #8145.
LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/126440043
|
|
LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/122910043
|
|
Fixes #5750.
https://code.google.com/p/go/issues/detail?id=5750
os: Separate windows from posix. Implement windows support.
path/filepath: Use the same implementation as other platforms
syscall: Add/rework new APIs for Windows
LGTM=alex.brainman
R=golang-codereviews, alex.brainman, gobot, rsc, minux
CC=golang-codereviews
https://golang.org/cl/86160044
|
|
Add nacl.bash, the NaCl version of all.bash.
It's a separate script because it builds a variant of package syscall
with a large zip file embedded in it, containing all the input files
needed for tests.
Disable various tests new since the last round, mostly the ones using os/exec.
Fixes #7945.
LGTM=dave
R=golang-codereviews, remyoudompheng, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/100590044
|
|
The comment for 'Clean' function is prepended with spaces instead of
a single tab, resulting in visually misaligned comment in the generated
documentation.
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/73840043
|
|
Fixes #6463.
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/69870050
|
|
See golang.org/s/go13nacl for design overview.
This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.
CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.
The exact change lists included are
15050047: syscall: support for Native Client
15360044: syscall: unzip implementation for Native Client
15370044: syscall: Native Client SRPC implementation
15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
15410048: runtime: support for Native Client
15410049: syscall: file descriptor table for Native Client
15410050: syscall: in-memory file system for Native Client
15440048: all: update +build lines for Native Client port
15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
15570045: os: support for Native Client
15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
15690044: net: support for Native Client
15690048: runtime: support for fake time like on Go Playground
15690051: build: disable various tests on Native Client
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68150047
|
|
R=golang-codereviews, minux.ma, gobot, rsc, dave
CC=golang-codereviews
https://golang.org/cl/36040043
|
|
os: don't ignore LStat errors in Readdir. If it's ENOENT,
on the second pass, just treat it as missing. If it's another
error, it's real.
path/filepath: use ReaddirNames instead of Readdir in Walk,
in order to obey the documented WalkFunc contract of returning
each walked item's LStat error, if any.
Fixes #6656
Fixes #6680
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/43530043
|
|
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/43290043
|
|
Bug3486 tried to walk the entire file tree, but other tests might
be creating and removing files in that tree. In particular, package os
creates and removes files in the os directory, and issue 5863
reports failures due to seeing those files appear and then disappear.
Change the test to walk just the test tree, which should not be
changing.
Fixes #5863.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13467045
|
|
Enable remaining packages (crypto, mime, path, time) to build on dragonfly.
R=bradfitz
CC=golang-dev
https://golang.org/cl/13190043
|
|
Update #5000
Should reduce the flakiness a little. Malloc counting is important
to general testing but not to the build dashboard, which uses -short.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/12866047
|
|
Uglier.
««« original CL description
all: use strings.IndexByte instead of Index where possible
R=golang-dev, khr
CC=golang-dev
https://golang.org/cl/12486043
»»»
R=golang-dev
CC=golang-dev
https://golang.org/cl/12485044
|
|
R=golang-dev, khr
CC=golang-dev
https://golang.org/cl/12486043
|
|
Fixes #5668.
R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/12001056
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9713044
|
|
Fixes #4974.
R=rsc, bradfitz, r
CC=golang-dev
https://golang.org/cl/7545043
|
|
Fixes #4930.
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/7424043
|
|
On Windows, directory names in PATH can be fully or partially quoted
in double quotes ('"'), but the path names as used by most APIs must
be unquoted. In addition, quoted names can contain the semicolon
(';') character, which is otherwise used as ListSeparator.
This CL changes SplitList in path/filepath and LookPath in os/exec
to only treat unquoted semicolons as separators, and to unquote the
separated elements.
(In addition, fix harmless test bug I introduced for LookPath on Unix.)
Related discussion thread:
https://groups.google.com/d/msg/golang-nuts/PXCr10DsRb4/sawZBM7scYgJ
R=rsc, minux.ma, mccoyst, alex.brainman, iant
CC=golang-dev
https://golang.org/cl/7181047
|
|
R=golang-dev, bradfitz, minux.ma
CC=golang-dev
https://golang.org/cl/7291043
|
|
This comment matches the one in path.
Fixes #4837.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7305100
|
|
If a test can be placed in the same package ("internal"), it is placed
there. This facilitates testing of package-private details. Because of
dependency cycles some packages cannot be tested by internal tests.
R=golang-dev, rsc, mikioh.mikioh
CC=golang-dev, r
https://golang.org/cl/7323044
|
|
Fixes #4759.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7304043
|
|
This CL also replaces similar loops in other stdlib
package tests with calls to AllocsPerRun.
Fixes #4461.
R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/7002055
|
|
also fix an annoying test that relies on $GOROOT be set.
Fixes #3690.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6844086
|
|
Remove trailing whitespace in comments.
No other changes.
R=r
CC=golang-dev
https://golang.org/cl/6815053
|
|
Define the properties of the arguments better. In particular,
explain that the path is (sort of) relative to the argument to
Walk.
Fixes #4119.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6721048
|
|
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6495059
|
|
Since NUL usually terminates strings in underlying syscalls, allowing
it when converting string arguments is a security risk, especially
when dealing with filenames. For example, a program might reason that
filename like "/root/..\x00/" is a subdirectory or "/root/" and allow
access to it, while underlying syscall will treat "\x00" as an end of
that string and the actual filename will be "/root/..", which might
be unexpected. Returning EINVAL when string arguments have NUL in
them makes sure this attack vector is unusable.
R=golang-dev, r, bradfitz, fullung, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6458050
|
|
(fix build)
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6344049
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6350047
|
|
Alternative to https://golang.org/cl/6330044.
Fixes #3681.
R=golang-dev, r, hanwen, iant
CC=golang-dev
https://golang.org/cl/6335056
|
|
Make it possible to run test over symlinked GOROOT.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6268046
|
|
Currently walk() doesn't check for err == SkipDir when iterating
a directory list, but such promise is made in the docs for WalkFunc.
Fixes #3486.
R=rsc, r
CC=golang-dev
https://golang.org/cl/6257059
|
|
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6117063
|
|
Fixes #3492.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6112044
|
|
Fixes #3476.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5986045
|
|
R=golang-dev, r
CC=golang-dev, hcwfrichter
https://golang.org/cl/5934046
|
|
do its work
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5928043
|
|
Fixes #3347.
R=golang-dev, aram, r, rsc
CC=golang-dev
https://golang.org/cl/5918043
|
|
R=golang-dev, r
CC=golang-dev, mattn.jp
https://golang.org/cl/5885056
|
|
As discussed on golang-dev, windows will use
"\" as path separator. No escaping allowed.
R=golang-dev, r, mattn.jp, rsc, rogpeppe, bsiegert, r
CC=golang-dev
https://golang.org/cl/5825044
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5781058
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5756049
|
|
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5756064
|
|
SameFile has a bug.
R=golang-dev
TBR=rsc
CC=golang-dev
https://golang.org/cl/5754055
|
|
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5759051
|