aboutsummaryrefslogtreecommitdiff
path: root/src/pkg/os/exec/exec.go
AgeCommit message (Collapse)Author
2014-09-08build: move package sources from src/pkg to srcRuss Cox
Preparation was in CL 134570043. This CL contains only the effect of 'hg mv src/pkg/* src'. For more about the move, see golang.org/s/go14nopkg.
2014-07-16src, misc: applied gofmt -s -wRobert Griesemer
Pending CL 113120043. LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/112290043
2014-04-15os/exec: make TestPipeLookPathLeak more verbose when it failsBrad Fitzpatrick
Trying to understand the linux-386-387 failures: http://build.golang.org/log/78a91da173c11e986b4e623527c2d0b746f4e814 Also modernize the closeOnce code with a method value, while I was looking. LGTM=adg R=golang-codereviews, adg CC=golang-codereviews, iant https://golang.org/cl/87950044
2014-04-04os/exec: always try appropriate command extensions during Cmd.Start on windowsAlex Brainman
Update #7362 Fixes #7377 Fixes #7570 LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/83020043
2014-02-23os/exec: explicitly mention Cmd.Wait() has to be called eventuallyPatrick Mézard
LGTM=minux.ma, r R=golang-codereviews, minux.ma, r CC=golang-codereviews https://golang.org/cl/67280043
2014-02-07os/exec: use filepath.Base in CommandAlex Brainman
filepath.Base covers all scenarios (for example paths like d:hello.txt) on windows LGTM=iant, bradfitz R=golang-codereviews, iant, bradfitz CC=golang-codereviews https://golang.org/cl/59740050
2014-02-03os/exec: fix Command with relative pathsBrad Fitzpatrick
Command was (and is) documented like: "If name contains no path separators, Command uses LookPath to resolve the path to a complete name if possible. Otherwise it uses name directly." But that wasn't true. It always did LookPath, and then set a sticky error that the user couldn't unset. And then if cmd.Dir was changed, Start would still fail due to the earlier sticky error being set. This keeps LookPath in the same place as before (so no user visible changes in cmd.Path after Command), but only does it when the documentation says it will happen. Also, clarify the docs about a relative Dir path. No change in any existing behavior, except using Command is now possible with relative paths. Previously it only worked if you built the *Cmd by hand. Fixes #7228 LGTM=iant R=iant CC=adg, golang-codereviews https://golang.org/cl/59580044
2013-09-13os/exec: add more caveats to StdoutPipe, StderrPipeRuss Cox
(StdinPipe was taken care of by CL 13329043.) Fixes #6008. R=golang-dev, iant CC=golang-dev https://golang.org/cl/13606046
2013-08-29os/exec: return idempotent Closer from StdinPipeAndrew Gerrand
Before this fix, it was always an error to use the Close method on the io.WriteCloser obtained from Cmd.StdinPipe, as it would race with the Close performed by Cmd.Wait. Fixes #6270. R=golang-dev, r, remyoudompheng, bradfitz, dsymonds CC=golang-dev https://golang.org/cl/13329043
2013-03-18os/exec: fix fd leak with Std*Pipe + LookPathBrad Fitzpatrick
If LookPath in Command fails, sets a sticky error, and then StdinPipe, StdoutPipe, or StderrPipe were called, those pipe fds were never cleaned up. Fixes #5071 R=golang-dev, rogpeppe CC=golang-dev https://golang.org/cl/7799046
2012-10-30gofmt: apply gofmt -w src miscRobert Griesemer
Remove trailing whitespace in comments. No other changes. R=r CC=golang-dev https://golang.org/cl/6815053
2012-09-14os/exec: don't crash when out of fdsBrad Fitzpatrick
Command.Start could crash before if no fds were available because a nil *os.File of /dev/null was added to the cleanup list, which crashed before returning the proper error. R=golang-dev, iant CC=golang-dev https://golang.org/cl/6514043
2012-07-09pkg: Removing duplicated words ("of of", etc.), mostly from comments.David G. Andersen
Ran 'double.pl' on the pkg tree to identify doubled words. One change to an error string return in x509; the rest are in comments. Thanks to Matt Jibson for the idea. R=golang-dev, bsiegert CC=golang-dev https://golang.org/cl/6344089
2012-04-27os/exec: close all internal descriptors when Cmd.Start() fails.Brian Dellisanti
This closes any internal descriptors (pipes, etc) that Cmd.Start() had opened before it failed. Fixes #3468. R=golang-dev, iant, bradfitz CC=golang-dev https://golang.org/cl/5986044
2012-03-12os/exec: fix typo in documentationFazlul Shahriar
R=golang-dev, gri CC=golang-dev https://golang.org/cl/5797073
2012-02-21os: replace non-portable Waitmsg with portable ProcessStateRob Pike
Use methods for key questions. Provide access to non-portable pieces through portable methods. Windows and Plan 9 updated. R=golang-dev, bradfitz, bradfitz, r, dsymonds, rsc, iant, iant CC=golang-dev https://golang.org/cl/5673077
2012-02-20os: drop the Wait function and the options to Process.WaitRob Pike
They are portability problems and the options are almost always zero in practice anyway. R=golang-dev, dsymonds, r, bradfitz CC=golang-dev https://golang.org/cl/5688046
2012-02-10os/exec: add Cmd.Waitmsg, fix a misleading commentBrad Fitzpatrick
Fixes #2948 R=golang-dev, r CC=golang-dev https://golang.org/cl/5655048
2011-12-21exec: disable the ExtraFiles test on darwinBrad Fitzpatrick
Still a mystery. New issue 2603 filed. R=golang-dev, dsymonds, iant CC=golang-dev https://golang.org/cl/5503063
2011-11-09os/exec: Fix documentation references to os.DevNullScott Lawrence
R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/5372049
2011-11-03os,text,unicode: renamingsRob Pike
This is Go 1 package renaming CL #4. This one merely moves the source; the import strings will be changed after the next weekly release. This one moves pieces into os, text, and unicode. exec -> os/exec scanner -> text/scanner tabwriter -> text/tabwriter template -> text/template template/parse -> text/template/parse utf16 -> unicode/utf16 utf8 -> unicode/utf8 This should be the last of the source-rearranging CLs. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5331066