os/exec: use filepath.Base in Command

filepath.Base covers all scenarios
(for example paths like d:hello.txt)
on windows

LGTM=iant, bradfitz
R=golang-codereviews, iant, bradfitz
CC=golang-codereviews
https://golang.org/cl/59740050

1 files changed, 2 insertions, 10 deletions

diff --git a/src/pkg/os/exec/exec.go b/src/pkg/os/exec/exec.go
index ea4f692a31..4680036fdd 100644
--- a/src/pkg/os/exec/exec.go
+++ b/src/pkg/os/exec/exec.go
@@ -12,6 +12,7 @@ import (
 	"errors"
 	"io"
 	"os"
+	"path/filepath"
 	"strconv"
 	"sync"
 	"syscall"
@@ -111,7 +112,7 @@ func Command(name string, arg ...string) *Cmd {
 		Path: name,
 		Args: append([]string{name}, arg...),
 	}
-	if !containsPathSeparator(name) {
+	if filepath.Base(name) == name {
 		if lp, err := LookPath(name); err != nil {
 			cmd.lookPathErr = err
 		} else {
@@ -121,15 +122,6 @@ func Command(name string, arg ...string) *Cmd {
 	return cmd
 }
 
-func containsPathSeparator(s string) bool {
-	for i := 0; i < len(s); i++ {
-		if os.IsPathSeparator(s[i]) {
-			return true
-		}
-	}
-	return false
-}
-
 // interfaceEqual protects against panics from doing equality tests on
 // two interfaces with non-comparable underlying types.
 func interfaceEqual(a, b interface{}) bool {