diff options
| author | Austin Clements <austin@google.com> | 2016-12-16 11:57:25 -0500 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2016-12-19 21:02:53 +0000 |
| commit | ddd558e7e407b9fb0ba27f5a80fdc8b17a8e466f (patch) | |
| tree | 69beb32d5c3193fc361fe919444aec688c6d8207 /src/runtime/traceback.go | |
| parent | 8d2169104467a14dea5705beb8ea351c68c5595d (diff) | |
| download | go-ddd558e7e407b9fb0ba27f5a80fdc8b17a8e466f.tar.xz | |
runtime: clean up and improve reflect.methodValue comments
The runtime no longer hard-codes the offset of
reflect.methodValue.stack, so remove these obsolete comments. Also,
reflect.methodValue and runtime.reflectMethodValue must also agree
with reflect.makeFuncImpl, so update the comments on all three to
mention this.
This was pointed out by Minux on CL 31138.
Change-Id: Ic5ed1beffb65db76aca2977958da35de902e8e58
Reviewed-on: https://go-review.googlesource.com/34590
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/runtime/traceback.go')
| -rw-r--r-- | src/runtime/traceback.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/runtime/traceback.go b/src/runtime/traceback.go index 0049e82d63..180489fb2c 100644 --- a/src/runtime/traceback.go +++ b/src/runtime/traceback.go @@ -546,7 +546,8 @@ func gentraceback(pc0, sp0, lr0 uintptr, gp *g, skip int, pcbuf *uintptr, max in return n } -// reflectMethodValue is a partial duplicate of reflect.methodValue. +// reflectMethodValue is a partial duplicate of reflect.makeFuncImpl +// and reflect.methodValue. type reflectMethodValue struct { fn uintptr stack *bitvector // args bitmap |