From ddd558e7e407b9fb0ba27f5a80fdc8b17a8e466f Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 16 Dec 2016 11:57:25 -0500 Subject: runtime: clean up and improve reflect.methodValue comments The runtime no longer hard-codes the offset of reflect.methodValue.stack, so remove these obsolete comments. Also, reflect.methodValue and runtime.reflectMethodValue must also agree with reflect.makeFuncImpl, so update the comments on all three to mention this. This was pointed out by Minux on CL 31138. Change-Id: Ic5ed1beffb65db76aca2977958da35de902e8e58 Reviewed-on: https://go-review.googlesource.com/34590 Reviewed-by: Keith Randall --- src/runtime/traceback.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/runtime/traceback.go') diff --git a/src/runtime/traceback.go b/src/runtime/traceback.go index 0049e82d63..180489fb2c 100644 --- a/src/runtime/traceback.go +++ b/src/runtime/traceback.go @@ -546,7 +546,8 @@ func gentraceback(pc0, sp0, lr0 uintptr, gp *g, skip int, pcbuf *uintptr, max in return n } -// reflectMethodValue is a partial duplicate of reflect.methodValue. +// reflectMethodValue is a partial duplicate of reflect.makeFuncImpl +// and reflect.methodValue. type reflectMethodValue struct { fn uintptr stack *bitvector // args bitmap -- cgit v1.3-5-g9baa