diff options
| author | Alex Brainman <alex.brainman@gmail.com> | 2016-04-20 15:58:55 +1000 |
|---|---|---|
| committer | Alex Brainman <alex.brainman@gmail.com> | 2016-04-21 01:03:17 +0000 |
| commit | 285a18436d480ef91b2af236d5ddd2fa7fa49de8 (patch) | |
| tree | bbe99429b59a91ea42783449b0ad55bb10af07c5 /src/debug/pe/file.go | |
| parent | 75b886ab790782f34945c0e1b0dee4189399ac9e (diff) | |
| download | go-285a18436d480ef91b2af236d5ddd2fa7fa49de8.tar.xz | |
debug/pe: pretty section.go code
Introduce (*SectionHeader32).fullName and add documentation comments.
Updates #15345
Change-Id: I8f3b8ab9492642d62e7aad010c91c68daea3f14b
Reviewed-on: https://go-review.googlesource.com/22301
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/debug/pe/file.go')
| -rw-r--r-- | src/debug/pe/file.go | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/src/debug/pe/file.go b/src/debug/pe/file.go index 3affd25185..73b7c1cba2 100644 --- a/src/debug/pe/file.go +++ b/src/debug/pe/file.go @@ -12,7 +12,6 @@ import ( "fmt" "io" "os" - "strconv" ) // A File represents an open PE file. @@ -172,12 +171,9 @@ func NewFile(r io.ReaderAt) (*File, error) { if err := binary.Read(sr, binary.LittleEndian, sh); err != nil { return nil, err } - var name string - if sh.Name[0] == '\x2F' { - si, _ := strconv.Atoi(cstring(sh.Name[1:])) - name, _ = getString(ss, si) - } else { - name = cstring(sh.Name[0:]) + name, err := sh.fullName(f.StringTable) + if err != nil { + return nil, err } s := new(Section) s.SectionHeader = SectionHeader{ |