From 285a18436d480ef91b2af236d5ddd2fa7fa49de8 Mon Sep 17 00:00:00 2001 From: Alex Brainman Date: Wed, 20 Apr 2016 15:58:55 +1000 Subject: debug/pe: pretty section.go code Introduce (*SectionHeader32).fullName and add documentation comments. Updates #15345 Change-Id: I8f3b8ab9492642d62e7aad010c91c68daea3f14b Reviewed-on: https://go-review.googlesource.com/22301 Reviewed-by: Ian Lance Taylor Run-TryBot: Alex Brainman TryBot-Result: Gobot Gobot --- src/debug/pe/file.go | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'src/debug/pe/file.go') diff --git a/src/debug/pe/file.go b/src/debug/pe/file.go index 3affd25185..73b7c1cba2 100644 --- a/src/debug/pe/file.go +++ b/src/debug/pe/file.go @@ -12,7 +12,6 @@ import ( "fmt" "io" "os" - "strconv" ) // A File represents an open PE file. @@ -172,12 +171,9 @@ func NewFile(r io.ReaderAt) (*File, error) { if err := binary.Read(sr, binary.LittleEndian, sh); err != nil { return nil, err } - var name string - if sh.Name[0] == '\x2F' { - si, _ := strconv.Atoi(cstring(sh.Name[1:])) - name, _ = getString(ss, si) - } else { - name = cstring(sh.Name[0:]) + name, err := sh.fullName(f.StringTable) + if err != nil { + return nil, err } s := new(Section) s.SectionHeader = SectionHeader{ -- cgit v1.3-5-g9baa