aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShulhan <ms@kilabit.info>2018-11-30 08:53:31 +0700
committerShulhan <ms@kilabit.info>2018-11-30 08:53:31 +0700
commitda0218f4625b59a93fbeec68e6d2a8d7abf2bd39 (patch)
tree039a78458b45f2506ad63e2a5fccbcd2bc1e8ae1
parentedc41b72b95c3f38ec5c5a0424693a7051175715 (diff)
downloadrescached-da0218f4625b59a93fbeec68e6d2a8d7abf2bd39.tar.xz
Remove unused message pool
-rw-r--r--cacheworker.go8
-rw-r--r--messagepool.go24
-rw-r--r--rescached.go3
3 files changed, 2 insertions, 33 deletions
diff --git a/cacheworker.go b/cacheworker.go
index c1553d5..d6c5376 100644
--- a/cacheworker.go
+++ b/cacheworker.go
@@ -48,10 +48,7 @@ func (cw *cacheWorker) start() {
for {
select {
case msg := <-cw.addQueue:
- added := cw.add(msg, false)
- if !added {
- freeMessage(msg)
- }
+ _ = cw.add(msg, false)
case res := <-cw.updateQueue:
cw.update(res)
@@ -114,8 +111,7 @@ func (cw *cacheWorker) add(msg *dns.Message, isLocal bool) bool {
return true
}
- oldMsg := lres.update(res, msg)
- freeMessage(oldMsg)
+ _ = lres.update(res, msg)
if !isLocal {
cw.cachesList.fix(res)
diff --git a/messagepool.go b/messagepool.go
deleted file mode 100644
index 194d721..0000000
--- a/messagepool.go
+++ /dev/null
@@ -1,24 +0,0 @@
-// Copyright 2018, Shulhan <ms@kilabit.info>. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
-package rescached
-
-import (
- "sync"
-
- "github.com/shuLhan/share/lib/dns"
-)
-
-var _messagePool = sync.Pool{
- New: func() interface{} {
- return dns.NewMessage()
- },
-}
-
-//
-// freeMessage put the message back to the pool.
-//
-func freeMessage(msg *dns.Message) {
- _messagePool.Put(msg)
-}
diff --git a/rescached.go b/rescached.go
index 7201759..81eff3a 100644
--- a/rescached.go
+++ b/rescached.go
@@ -431,9 +431,6 @@ func (srv *Server) processForwardResponse(req *dns.Request, res *dns.Message) {
}
}
if !ok {
- if res != nil {
- freeMessage(res)
- }
srv.freeRequests(req)
return
}