all: comply with linter recommendations #2

HTTP request now implicitly create request with context.

Any false positive related to not closing HTTP response body has been
annotated with "nolint:bodyclose".

In the example code, use consistent "// Output:" comment format, by
prefixing with single space.
Any comment on code now also prefixing with single space.

An error returned without variables now use [errors.New] instead of
[fmt.Errorf].
Any error returned using [fmt.Errorf] now wrapped using "%w" instead of
"%s".
Also, replace error checking using [errors.Is] or [errors.As], instead
of using equal/not-equal operator.

Any statement like "x = x OP y" now replaced with "x OP= y".
Also, swap statement is simplified using "x, y = y, x".
Any switch statement with single case now replaced with if-condition.

Any call to defer on function or program that call [os.Exit], now
replaced by calling the deferred function directly.

Any if-else condition now replaced with switch statement, if possible.

1 files changed, 2 insertions, 2 deletions

diff --git a/lib/http/client_test.go b/lib/http/client_test.go
index b92b3b11..56ff4333 100644
--- a/lib/http/client_test.go
+++ b/lib/http/client_test.go
@@ -44,7 +44,7 @@ func TestClient_Download(t *testing.T) {
 			},
 			Output: &out,
 		},
-		expError: fmt.Sprintf("%s: 404 Not Found", logp),
+		expError: logp + `: 404 Not Found`,
 	}, {
 		desc: "With redirect",
 		req: DownloadRequest{
@@ -82,7 +82,7 @@ func TestClient_Download(t *testing.T) {
 	for _, c := range cases {
 		out.Reset()
 
-		_, err = client.Download(c.req)
+		_, err = client.Download(c.req) //nolint: bodyclose
 		if err != nil {
 			test.Assert(t, c.desc+`: error`, c.expError, err.Error())
 			continue