aboutsummaryrefslogtreecommitdiff
path: root/lib/git/git.go
diff options
context:
space:
mode:
authorShulhan <ms@kilabit.info>2024-03-03 04:59:34 +0700
committerShulhan <ms@kilabit.info>2024-03-05 14:53:12 +0700
commit2fa7605727e90ca323b7b24168632e485d74c583 (patch)
tree3533df0fc07ef96b1564736926cc3310994be515 /lib/git/git.go
parentb921ebfb3e81b367ff24305eb18c5dd073b38635 (diff)
downloadpakakeh.go-2fa7605727e90ca323b7b24168632e485d74c583.tar.xz
all: comply with linter recommendations #2
HTTP request now implicitly create request with context. Any false positive related to not closing HTTP response body has been annotated with "nolint:bodyclose". In the example code, use consistent "// Output:" comment format, by prefixing with single space. Any comment on code now also prefixing with single space. An error returned without variables now use [errors.New] instead of [fmt.Errorf]. Any error returned using [fmt.Errorf] now wrapped using "%w" instead of "%s". Also, replace error checking using [errors.Is] or [errors.As], instead of using equal/not-equal operator. Any statement like "x = x OP y" now replaced with "x OP= y". Also, swap statement is simplified using "x, y = y, x". Any switch statement with single case now replaced with if-condition. Any call to defer on function or program that call [os.Exit], now replaced by calling the deferred function directly. Any if-else condition now replaced with switch statement, if possible.
Diffstat (limited to 'lib/git/git.go')
-rw-r--r--lib/git/git.go5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/git/git.go b/lib/git/git.go
index af93bb56..0f73b2b7 100644
--- a/lib/git/git.go
+++ b/lib/git/git.go
@@ -7,6 +7,7 @@ package git
import (
"bytes"
+ "errors"
"fmt"
"io"
"os"
@@ -166,10 +167,10 @@ func GetRemoteURL(repoDir, remoteName string) (url string, err error) {
url, ok := gitIni.Get("remote", remoteName, "url", "")
if !ok {
- err = fmt.Errorf("GetRemote: Empty or invalid remote name")
+ return ``, errors.New(`GetRemote: Empty or invalid remote name`)
}
- return
+ return url, nil
}
// GetTag get the tag from revision. If revision is empty it's default to