diff options
| author | Shulhan <ms@kilabit.info> | 2019-04-07 10:34:29 +0700 |
|---|---|---|
| committer | Shulhan <ms@kilabit.info> | 2019-04-12 12:50:41 +0700 |
| commit | ce558fb263d4bdef58ebfd801331c6b074349f33 (patch) | |
| tree | 0c7b608406788044c33f243bc265b95a4e3cc491 /lib/dns | |
| parent | de01a0d888b124c5d27005442ef62bd155227484 (diff) | |
| download | pakakeh.go-ce558fb263d4bdef58ebfd801331c6b074349f33.tar.xz | |
dns: detach generate test response from test serverHandler
The function that generate test responses will save the response in
global variables _testResponses. This is required when we refactor
unit test later to minimize global variable.
Diffstat (limited to 'lib/dns')
| -rw-r--r-- | lib/dns/dns_test.go | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/lib/dns/dns_test.go b/lib/dns/dns_test.go index 63defbec..7929e168 100644 --- a/lib/dns/dns_test.go +++ b/lib/dns/dns_test.go @@ -28,7 +28,7 @@ type serverHandler struct { responses []*Message } -func (h *serverHandler) generateResponses() { +func generateTestResponses() (responses []*Message) { // kilabit.info A res := &Message{ Header: &SectionHeader{ @@ -60,7 +60,7 @@ func (h *serverHandler) generateResponses() { log.Fatal("Pack: ", err) } - h.responses = append(h.responses, res) + responses = append(responses, res) // kilabit.info SOA res = &Message{ @@ -98,7 +98,7 @@ func (h *serverHandler) generateResponses() { log.Fatal("Pack: ", err) } - h.responses = append(h.responses, res) + responses = append(responses, res) // kilabit.info TXT res = &Message{ @@ -130,7 +130,9 @@ func (h *serverHandler) generateResponses() { log.Fatal("Pack: ", err) } - h.responses = append(h.responses, res) + responses = append(responses, res) + + return responses } func (h *serverHandler) ServeDNS(req *Request) { @@ -207,7 +209,7 @@ func TestMain(m *testing.M) { _testHandler = &serverHandler{} - _testHandler.generateResponses() + _testHandler.responses = generateTestResponses() _testServer = &Server{ Handler: _testHandler, |