| Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
Change-Id: Ia685c5bc68d3e13e3225eaf8db062d1b593d995e
|
|
|
|
Change-Id: I830a3bf4cfffe96f90c68e725d3806114543f360
GitHub-Last-Rev: dcefcf469c789f262d8452f6a642aa31d235f172
GitHub-Pull-Request: golang/tour#878
Reviewed-on: https://go-review.googlesource.com/c/tour/+/212817
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
|
|
Fixes golang/tour#445
Change-Id: I69702bc5b3882188e8867e8112ec8e689e1ffb03
Reviewed-on: https://go-review.googlesource.com/123255
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
|
|
A few tour slides end with a Note with some additional remarks. Most
of the times the word "Note:" is in bold, and the next word is
capitalized, except in a few places. Uniform the style by making it
always bold and by always capitalizing the sentence.
Change-Id: Ib5843a55c0e9a4f602efa0346f96702493a7284a
Reviewed-on: https://go-review.googlesource.com/123215
Reviewed-by: Andrew Bonventre <andybons@golang.org>
|
|
Added a link to methods/25 to moretypes/18 because they are related.
This improves the usability of the page.
Fixes golang/tour#95
Change-Id: I3ec7e85267d0e5da9c67194dce58d5310eefc97b
GitHub-Last-Rev: 1fe64640097e65af0ddbd058b908f765a9aaf7da
GitHub-Pull-Request: golang/tour#471
Reviewed-on: https://go-review.googlesource.com/110118
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
|
|
Fixes golang/tour#202.
Change-Id: Ibffa127f6bdbe9c2ce8d47f358d355795e214a2b
Reviewed-on: https://go-review.googlesource.com/40897
Reviewed-by: Chris Broadfoot <cbro@golang.org>
|
|
Fixes golang/go#13962
Change-Id: I2a35d67677bd4a4267fedf542428267ece22b52e
Reviewed-on: https://go-review.googlesource.com/18793
Reviewed-by: Francesc Campoy Flores <campoy@golang.org>
|
|
Fixes golang/go#13951
Change-Id: I5c830371f987c114f37344d00a68f4b0735f47eb
Reviewed-on: https://go-review.googlesource.com/18670
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
|
|
Change-Id: Ib1463519bac971b5b19952ca366de8bad58c25d7
Reviewed-on: https://go-review.googlesource.com/18425
Reviewed-by: Rob Pike <r@golang.org>
|
|
Fixes golang/go#13818
Change-Id: I22817c0c3bfa3d7e5a769f239a2521c293112a43
Reviewed-on: https://go-review.googlesource.com/18246
Reviewed-by: Rob Pike <r@golang.org>
|
|
Update golang/go#13012
Change-Id: I62277ba3c8bcb57c8e8da5d00faec77c2a1ffa04
Reviewed-on: https://go-review.googlesource.com/17162
Reviewed-by: Katrina Owen <katrina.owen@gmail.com>
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
Some readers became confused because the server doesn't
register a handler for "/", causing them to get a 404
on localhost:4000 even when having completed the exercise
correctly.
Fixes golang/go#13012
Change-Id: I97ba511ca0b38097e5b54b75a7478c7c59912e43
Reviewed-on: https://go-review.googlesource.com/16923
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
The example showing error handling has the right shape,
but does not break after printing an error message, causing
the execution to continue with the happy-path case regardless
of whether or not there was an error.
Despite there not being any evident scope here, a return shows
what the idiomatic control flow would look like.
Fixes golang/go#12926
Change-Id: I54f8cfaf5d4bbc193089a320342272bfe2fe20f6
Reviewed-on: https://go-review.googlesource.com/15861
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
Also remove outdated link to the App Engine SDK.
Change-Id: I235359a7ee806d5c537e4654cc8ccc68bea043ec
Reviewed-on: https://go-review.googlesource.com/15059
Reviewed-by: Katrina Owen <katrina.owen@gmail.com>
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
Change-Id: Ib3fcc8c1bec38b7b9fae426d61161e1ce2982ded
Reviewed-on: https://go-review.googlesource.com/12718
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
Fixes golang/go#10667.
Change-Id: Ib6a61d6865f64abe8a659ee2087d30cdc1835401
Reviewed-on: https://go-review.googlesource.com/9671
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
Fixes #184.
LGTM=minux
R=campoy, minux
CC=golang-codereviews
https://golang.org/cl/183100043
|
|
LGTM=campoy
R=campoy
CC=golang-codereviews
https://golang.org/cl/118170043
|
|
As the prog/tour directory grows it becomes more difficult to see
what belongs where. Also the prog/tour directory hierarchy is one
level too deep.
Here's the code used to make this change:
for article in *.article; do
base=$(echo $article | sed 's/.article//')
mkdir $base
gofiles=$(grep '^.play' $article | awk '{print $2}' | sed 's_prog/tour/__' | sort -u)
for f in $gofiles; do
hg mv prog/tour/$f $base/$f
done
sed -i '' 's_prog/tour_'$base'_' $article
done
# catch dreg masked by "#appengine: " comment directive
hg mv prog/tour/sandbox.go welcome/
LGTM=campoy
R=campoy
CC=golang-codereviews
https://golang.org/cl/111250043
|
|
Those changes were mistakenly applied to release-branch.go1.3.
TBR=campoy
R=campoy
CC=golang-codereviews
https://golang.org/cl/113240043
|
|
The web UI has been implemented from scratch using AngularJS and fetches the content of the modules via a REST APi.
The tour has been split into different modules composed by a list of lessons.
When a new lesson is added it will be accessible publicly, but it won't appear in the list of modules until the corresponding `lesson` element is added to list.html.
The new version is accessible at http://campoy.cat/gotour
LGTM=adg
R=r, adg, kamil.kisiel, egonelbre, nightlyone, dan.kortschak, gobot, bradfitz, davidday
CC=golang-codereviews
https://golang.org/cl/36500046
|