| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
* Perbaikan URL pada isi method.
Change-Id: Ibbf7d2efe05938a26f90821cb3f00584ff328c59
|
|
|
|
The lack of agreement in tense between the parallel verbs `execute` (_are executed_) and `return` in this sentence threw me. This simpler construction is more grammatically correct, according to some standards, and less confusing to me.
Change-Id: I6351ce29a684d9b0d18f57b914072c43219401aa
GitHub-Last-Rev: c6f29ca49a4e523c6d2cd2476f66a22fb7448881
GitHub-Pull-Request: golang/tour#629
Reviewed-on: https://go-review.googlesource.com/c/141577
Reviewed-by: Rob Pike <r@golang.org>
|
|
Fixes golang/tour#575
Change-Id: Ic86fcddbd72b6a54e75b794b0b760151e2a4b78c
Reviewed-on: https://go-review.googlesource.com/128536
Reviewed-by: Andrew Bonventre <andybons@golang.org>
|
|
A few tour slides end with a Note with some additional remarks. Most
of the times the word "Note:" is in bold, and the next word is
capitalized, except in a few places. Uniform the style by making it
always bold and by always capitalizing the sentence.
Change-Id: Ib5843a55c0e9a4f602efa0346f96702493a7284a
Reviewed-on: https://go-review.googlesource.com/123215
Reviewed-by: Andrew Bonventre <andybons@golang.org>
|
|
Also don't assume prior knowledge of switch statement,
which I noticed right below the Sqrt exercise.
Change-Id: I1f3e191aa924a79c822780353a526d8edaafc168
Reviewed-on: https://go-review.googlesource.com/72130
Reviewed-by: Austin Clements <austin@google.com>
|
|
The hint text says
give it floating point syntax or use a conversion
but the code has the conversion first and the fp syntax after that.
Swap them.
Fixes golang/tour#286
Change-Id: I96413285ed185451511fd32cadf5bccfe1ce566d
Reviewed-on: https://go-review.googlesource.com/56350
Reviewed-by: Rob Phoenix <rob@robphoenix.com>
Reviewed-by: Avelino <t@avelino.xxx>
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
|
|
Fixes golang/tour#27
Change-Id: Idcaf9b2ad7f08ea20b7bd1f7f1ff600cb43e2d55
Reviewed-on: https://go-review.googlesource.com/51070
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
|
|
Change-Id: Ie3473dfcfbd7272d40ff26110261f721f74d026a
Reviewed-on: https://go-review.googlesource.com/33930
Reviewed-by: Jaana Burcu Dogan <jbd@google.com>
|
|
Fixes #7
Change-Id: Ifd2bf48ceaa3e61771f7bf38c17b5be7ed0bc197
Reviewed-on: https://go-review.googlesource.com/22361
Reviewed-by: Francesc Campoy Flores <campoy@golang.org>
|
|
Give a better explanation and make comparisons to C and Java less
relevant
Change-Id: I4fa612915c582ce064f18f9d3193627c947f61e4
Reviewed-on: https://go-review.googlesource.com/16862
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
Also remove outdated link to the App Engine SDK.
Change-Id: I235359a7ee806d5c537e4654cc8ccc68bea043ec
Reviewed-on: https://go-review.googlesource.com/15059
Reviewed-by: Katrina Owen <katrina.owen@gmail.com>
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
The slide is about variable scope, but some readers
were confused by the order of the print statements.
This hint should point them in the right direction.
Fixes golang/go#11684
Change-Id: Ica0215457c6878374125ec1b8a5d9b52ebbff38a
Reviewed-on: https://go-review.googlesource.com/15607
Reviewed-by: Andrew Gerrand <adg@golang.org>
|
|
Fixes golang/go#10620.
Change-Id: I52d6eddc6e59d1f7812117b0923a01f632d28d29
Reviewed-on: https://go-review.googlesource.com/9494
Reviewed-by: Francesc Campoy Flores <campoy@golang.org>
|
|
As the prog/tour directory grows it becomes more difficult to see
what belongs where. Also the prog/tour directory hierarchy is one
level too deep.
Here's the code used to make this change:
for article in *.article; do
base=$(echo $article | sed 's/.article//')
mkdir $base
gofiles=$(grep '^.play' $article | awk '{print $2}' | sed 's_prog/tour/__' | sort -u)
for f in $gofiles; do
hg mv prog/tour/$f $base/$f
done
sed -i '' 's_prog/tour_'$base'_' $article
done
# catch dreg masked by "#appengine: " comment directive
hg mv prog/tour/sandbox.go welcome/
LGTM=campoy
R=campoy
CC=golang-codereviews
https://golang.org/cl/111250043
|
|
LGTM=adg
R=adg, campoy
CC=golang-codereviews
https://golang.org/cl/110520043
|
|
The web UI has been implemented from scratch using AngularJS and fetches the content of the modules via a REST APi.
The tour has been split into different modules composed by a list of lessons.
When a new lesson is added it will be accessible publicly, but it won't appear in the list of modules until the corresponding `lesson` element is added to list.html.
The new version is accessible at http://campoy.cat/gotour
LGTM=adg
R=r, adg, kamil.kisiel, egonelbre, nightlyone, dan.kortschak, gobot, bradfitz, davidday
CC=golang-codereviews
https://golang.org/cl/36500046
|
