| Age | Commit message (Collapse) | Author |
|
Preparation was in CL 134570043.
This CL contains only the effect of 'hg mv src/pkg/* src'.
For more about the move, see golang.org/s/go14nopkg.
|
|
In cgo, now that recursive calls to typeConv.Type() always work,
we can more robustly calculate the array sizes based on the size
of our element type.
Also, in debug/dwarf, the decision to call zeroType is made
based on a type's usage within a particular struct, but dwarf.Type
values are cached in typeCache, so the modification might affect
uses of the type in other structs. Current compilers don't appear
to share DWARF type entries for "[]foo" and "[0]foo", but they also
don't consistently share type entries in other cases. Arguably
modifying the types is an improvement in some cases, but varying
translated types according to compiler whims seems like a bad idea.
Lastly, also in debug/dwarf, zeroType only needs to rewrite the
top-level dimension, and only if the rest of the array size is
non-zero.
Fixes #8428.
LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/127980043
|
|
LGTM=iant, bradfitz
R=bradfitz, iant
CC=golang-codereviews
https://golang.org/cl/120700043
|
|
The linker currently produces the DWARF 3 DW_TAG_unspecified_type tag, however the Reader in debug/dwarf will panic whenever that tag is encountered.
Fixes #8437.
LGTM=rsc
R=golang-codereviews, bradfitz, iant, rsc
CC=golang-codereviews
https://golang.org/cl/117280043
|
|
DWARF says only one is necessary.
The count is preferable because it admits 0-length arrays.
Update debug/dwarf to handle either form.
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/111230044
|
|
LGTM=iant
R=golang-codereviews, iant, bradfitz
CC=golang-codereviews, math-nuts
https://golang.org/cl/72820044
|
|
In DWARF 4 the debug info for large types is put into
.debug_type sections, so that the linker can discard duplicate
info. This change adds support for reading type units.
Another small change included here is that DWARF 3 supports
storing the byte offset of a struct field as a formData rather
than a formDwarfBlock.
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/56300043
|
|
The addrsize field is not a constant for an entire executable
file, and is now handled by the dataFormat interface when
reading the data.
R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/41620043
|
|
Some versions of clang generate DWARF 4-format attributes
even when using -gdwarf-2. We don't care much about the
values, but we do need to be able to parse past them.
This fixes a bug in Go 1.2 rc2 reported via private mail using
a near-tip version of clang.
R=golang-dev, iant, dvyukov
CC=golang-dev
https://golang.org/cl/18460043
|
|
R=golang-dev, r, minux.ma
CC=golang-dev
https://golang.org/cl/14669045
|
|
Fixes a bug in cgo on OS X using clang.
See golang.org/issue/6472 for details.
Fixes #6472.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14575043
|
|
R=rsc
CC=golang-dev
https://golang.org/cl/7662045
|
|
ref: http://www.dwarfstd.org/doc/DWARF4.pdf
Update #4829
R=minux.ma, iant
CC=dave, golang-dev
https://golang.org/cl/7354043
|
|
* disallow embedding of C type (Fixes issue 2552)
* detect 0-length array (Fixes issue 2806)
* use typedefs when possible, to avoid attribute((unavailable)) (Fixes issue 2888)
* print Go types constructed from C types using original C types (Fixes issue 2612)
This fix changes _cgo_export.h to repeat the preamble from import "C".
Otherwise the fix to issue 2612 is impossible, since it cannot refer to
types that have not been defined. If people are using //export and
putting non-header information in the preamble, they will need to
refactor their code.
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5672080
|
|
Fixes #2844.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5675072
|
|
Consequently, remove many package Makefiles,
and shorten the few that remain.
gomake becomes 'go tool make'.
Turn off test phases of run.bash that do not work,
flagged with $BROKEN. Future CLs will restore these,
but this seemed like a big enough CL already.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5601057
|
|
All but 3 cases (in gcimporter.go and hixie.go)
are automatic conversions using gofix.
No attempt is made to use the new Append functions
even though there are definitely opportunities.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5447069
|
|
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5322051
|
|
R=golang-dev, r, adg, r, cw
CC=golang-dev
https://golang.org/cl/5266045
|
|
manual changes in src/pkg/go/printer, src/cmd/gofix/signal_test.go
(cd src/cmd/gofix/testdata; gofmt -w *.in *.out)
(cd src/pkg/go/printer; gotest -update)
gofmt -w misc src
runs all tests
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4715041
|
|
R=gri
CC=golang-dev
https://golang.org/cl/4625044
|
|
That gcc does not include enumerator names and values
in its DWARF debug output. Create a data block from which
we can read the values instead.
Fixes #1881.
R=iant
CC=golang-dev
https://golang.org/cl/4607045
|
|
R=ality, bradfitz, rsc, dsymonds, adg, qyzhai, dchest
CC=golang-dev
https://golang.org/cl/4536063
|
|
R=rsc
CC=golang-dev
https://golang.org/cl/4442064
|
|
R=rsc
CC=binet, golang-dev
https://golang.org/cl/3906041
|
|
R=gri, r, r2
CC=golang-dev
https://golang.org/cl/2743042
|
|
R=gri
CC=golang-dev
https://golang.org/cl/2763041
|
|
R=adg, r, PeterGo
CC=golang-dev
https://golang.org/cl/1942044
|
|
Fixes #881.
R=iant
CC=golang-dev
https://golang.org/cl/1696044
|
|
R=r
CC=golang-dev
https://golang.org/cl/833044
|
|
- only manual changes are in src/pkg/go/printer/nodes.go
- use a heuristic to determine "outliers" such that not entire composites are
forced to align with them
- improves several places that were not unligned before due too simple heuristic
- unalignes some cases that contain "outliers"
- gofmt -w src misc
Fixes #644.
R=rsc, r
CC=golang-dev
https://golang.org/cl/241041
|
|
- gofmt -w src misc
- looking for feedback
R=rsc, r
CC=golang-dev
https://golang.org/cl/223076
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
2nd set of files.
R=rsc
CC=golang-dev
https://golang.org/cl/179067
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes #115.
R=rsc, dsymonds1
https://golang.org/cl/157067
|
|
R=r, gri
CC=golang-dev
https://golang.org/cl/156115
|
|
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1026036
|
|
R=rsc, r
http://go/go-review/1025029
|
|
R=ken
http://go/go-review/1026032
|
|
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/1026006
|
|
(excluding debug/gosym/symtab.go which has a small issue)
R=rsc
http://go/go-review/1019001
|
|
base85 -> encoding/ascii85, encoding/git85
debug/binary -> encoding/binary
R=r
DELTA=3190 (1884 added, 1297 deleted, 9 changed)
OCL=35923
CL=35929
|
|
R=gri
OCL=35485
CL=35488
|
|
R=gri
DELTA=2560 (127 added, 177 deleted, 2256 changed)
OCL=35388
CL=35395
|
|
R=r
DELTA=30 (24 added, 3 deleted, 3 changed)
OCL=34950
CL=34974
|
|
TBR=r
OCL=34803
CL=34803
|
|
TBR=r
OCL=34800
CL=34800
|
|
test both ELF and Mach-O in dwarf package.
R=r
DELTA=83 (44 added, 10 deleted, 29 changed)
OCL=34717
CL=34790
|
|
R=r
OCL=34731
CL=34731
|
|
R=r
DELTA=940 (929 added, 1 deleted, 10 changed)
OCL=34679
CL=34686
|
|
R=r
DELTA=949 (949 added, 0 deleted, 0 changed)
OCL=34676
CL=34678
|