diff options
Diffstat (limited to 'src/database/sql')
| -rw-r--r-- | src/database/sql/badlinkname.go | 1 | ||||
| -rw-r--r-- | src/database/sql/sql.go | 18 |
2 files changed, 14 insertions, 5 deletions
diff --git a/src/database/sql/badlinkname.go b/src/database/sql/badlinkname.go index a77def9fbd..95a2354afd 100644 --- a/src/database/sql/badlinkname.go +++ b/src/database/sql/badlinkname.go @@ -13,4 +13,3 @@ import _ "unsafe" // in new code. //go:linkname convertAssign -//go:linkname drivers diff --git a/src/database/sql/sql.go b/src/database/sql/sql.go index 9373aa1c58..de774a0510 100644 --- a/src/database/sql/sql.go +++ b/src/database/sql/sql.go @@ -29,12 +29,22 @@ import ( "sync" "sync/atomic" "time" + _ "unsafe" ) -var ( - driversMu sync.RWMutex - drivers = make(map[string]driver.Driver) -) +var driversMu sync.RWMutex + +// drivers should be an internal detail, +// but widely used packages access it using linkname. +// (It is extra wrong that they linkname drivers but not driversMu.) +// Notable members of the hall of shame include: +// - github.com/instana/go-sensor +// +// Do not remove or change the type signature. +// See go.dev/issue/67401. +// +//go:linkname drivers +var drivers = make(map[string]driver.Driver) // nowFunc returns the current time; it's overridden in tests. var nowFunc = time.Now |