diff options
| -rw-r--r-- | src/cmd/5g/reg.c | 6 | ||||
| -rw-r--r-- | src/cmd/6g/reg.c | 6 | ||||
| -rw-r--r-- | src/cmd/8g/reg.c | 6 | ||||
| -rw-r--r-- | test/fixedbugs/issue4066.go | 37 |
4 files changed, 52 insertions, 3 deletions
diff --git a/src/cmd/5g/reg.c b/src/cmd/5g/reg.c index 5f7ed2e88d..584ffc2534 100644 --- a/src/cmd/5g/reg.c +++ b/src/cmd/5g/reg.c @@ -1075,8 +1075,12 @@ prop(Reg *r, Bits ref, Bits cal) default: // Work around for issue 1304: // flush modified globals before each instruction. - for(z=0; z<BITS; z++) + for(z=0; z<BITS; z++) { cal.b[z] |= externs.b[z]; + // issue 4066: flush modified return variables in case of panic + if(hasdefer) + cal.b[z] |= ovar.b[z]; + } break; } for(z=0; z<BITS; z++) { diff --git a/src/cmd/6g/reg.c b/src/cmd/6g/reg.c index 8d15bf9790..9c9b74d0ed 100644 --- a/src/cmd/6g/reg.c +++ b/src/cmd/6g/reg.c @@ -1121,8 +1121,12 @@ prop(Reg *r, Bits ref, Bits cal) default: // Work around for issue 1304: // flush modified globals before each instruction. - for(z=0; z<BITS; z++) + for(z=0; z<BITS; z++) { cal.b[z] |= externs.b[z]; + // issue 4066: flush modified return variables in case of panic + if(hasdefer) + cal.b[z] |= ovar.b[z]; + } break; } for(z=0; z<BITS; z++) { diff --git a/src/cmd/8g/reg.c b/src/cmd/8g/reg.c index 80230bc866..7b8b39e8bc 100644 --- a/src/cmd/8g/reg.c +++ b/src/cmd/8g/reg.c @@ -1048,8 +1048,12 @@ prop(Reg *r, Bits ref, Bits cal) default: // Work around for issue 1304: // flush modified globals before each instruction. - for(z=0; z<BITS; z++) + for(z=0; z<BITS; z++) { cal.b[z] |= externs.b[z]; + // issue 4066: flush modified return variables in case of panic + if(hasdefer) + cal.b[z] |= ovar.b[z]; + } break; } for(z=0; z<BITS; z++) { diff --git a/test/fixedbugs/issue4066.go b/test/fixedbugs/issue4066.go new file mode 100644 index 0000000000..19cfe6651a --- /dev/null +++ b/test/fixedbugs/issue4066.go @@ -0,0 +1,37 @@ +// run + +// Copyright 2012 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// issue 4066: return values not being spilled eagerly enough + +package main + +func main() { + n := foo() + if n != 2 { + println(n) + panic("wrong return value") + } +} + +type terr struct{} + +func foo() (val int) { + val = 0 + defer func() { + if x := recover(); x != nil { + _ = x.(terr) + } + }() + for { + val = 2 + foo1() + } + panic("unreachable") +} + +func foo1() { + panic(terr{}) +} |
