diff options
| author | Keith Randall <khr@golang.org> | 2026-03-27 15:12:23 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2026-03-31 11:01:09 -0700 |
| commit | 1673075d4bd324e69cb4e6e58760316e2c84e604 (patch) | |
| tree | 0241cf5ff198bb149dec6843dfaef57dafb57c43 /test/codegen/writebarrier.go | |
| parent | 9387929d09490ae30a8da75c64d9c64e2c16936d (diff) | |
| download | go-1673075d4bd324e69cb4e6e58760316e2c84e604.tar.xz | |
test/codegen: fix broken syntax
A bunch of tests had broken yet undetected syntax errors
in their assembly output regexps. Things like mismatched quotes,
using ^ instead of - for negation, etc.
In addition, since CL 716060 using commas as separators between
regexps doesn't work, and ends up just silently dropping every
regexp after the comma.
Fix all these things, and add a test to make sure that we're not
silently dropping regexps on the floor.
After this CL I will do some cleanup to align with CL 716060, like
replacing commas and \s with spaces (which was the point of that CL,
but wasn't consistently rewritten everywhere).
Change-Id: I54f226120a311ead0c6c62eaf5d152ceed106034
Reviewed-on: https://go-review.googlesource.com/c/go/+/760521
Reviewed-by: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Paul Murphy <paumurph@redhat.com>
Auto-Submit: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'test/codegen/writebarrier.go')
| -rw-r--r-- | test/codegen/writebarrier.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/codegen/writebarrier.go b/test/codegen/writebarrier.go index c3c39c58f7..271d8d25d3 100644 --- a/test/codegen/writebarrier.go +++ b/test/codegen/writebarrier.go @@ -90,9 +90,9 @@ func issue71228(dst *S, ptr *int) { } func writeDouble(p *[2]*int, x, y *int) { - // arm64: `LDP\s`, `STP\s\(R[0-9]+, R[0-9]+\), \(`, + // arm64: `LDP\s`, `STP\s\(R[0-9]+, R[0-9]+\), \(` p[0] = x - // arm64: `STP\s\(R[0-9]+, R[0-9]+\), 16\(`, + // arm64: `STP\s\(R[0-9]+, R[0-9]+\), 16\(` p[1] = y } |