diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2024-02-03 10:47:28 +0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-07-23 17:16:29 +0000 |
| commit | fe87b586c036ae7ad25e22896cb90f95421545fe (patch) | |
| tree | 465865a1883b617ef31ddfe4c9a52b2d7ace4deb /src | |
| parent | 78c0ea5df7e864575c8fcae8528572c5284c0435 (diff) | |
| download | go-fe87b586c036ae7ad25e22896cb90f95421545fe.tar.xz | |
runtime: remove VZEROUPPER in asyncPreempt on darwin/amd64
Updates #37174
Updates #49233
Fixes #41152
Change-Id: I35b148c8bc132f02dd6a5a6bb48b711fb5c5df9e
Reviewed-on: https://go-review.googlesource.com/c/go/+/560955
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/runtime/mkpreempt.go | 13 | ||||
| -rw-r--r-- | src/runtime/preempt_amd64.s | 7 |
2 files changed, 0 insertions, 20 deletions
diff --git a/src/runtime/mkpreempt.go b/src/runtime/mkpreempt.go index 17544d6b21..08500a90d5 100644 --- a/src/runtime/mkpreempt.go +++ b/src/runtime/mkpreempt.go @@ -264,19 +264,6 @@ func genAMD64() { l.save() - // Apparently, the signal handling code path in darwin kernel leaves - // the upper bits of Y registers in a dirty state, which causes - // many SSE operations (128-bit and narrower) become much slower. - // Clear the upper bits to get to a clean state. See issue #37174. - // It is safe here as Go code don't use the upper bits of Y registers. - p("#ifdef GOOS_darwin") - p("#ifndef hasAVX") - p("CMPB internal∕cpu·X86+const_offsetX86HasAVX(SB), $0") - p("JE 2(PC)") - p("#endif") - p("VZEROUPPER") - p("#endif") - lSSE.save() p("CALL ·asyncPreempt2(SB)") lSSE.restore() diff --git a/src/runtime/preempt_amd64.s b/src/runtime/preempt_amd64.s index 94a84fb74c..8e3ed0d7c5 100644 --- a/src/runtime/preempt_amd64.s +++ b/src/runtime/preempt_amd64.s @@ -27,13 +27,6 @@ TEXT ·asyncPreempt(SB),NOSPLIT|NOFRAME,$0-0 MOVQ R13, 88(SP) MOVQ R14, 96(SP) MOVQ R15, 104(SP) - #ifdef GOOS_darwin - #ifndef hasAVX - CMPB internal∕cpu·X86+const_offsetX86HasAVX(SB), $0 - JE 2(PC) - #endif - VZEROUPPER - #endif MOVUPS X0, 112(SP) MOVUPS X1, 128(SP) MOVUPS X2, 144(SP) |