aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorBryan C. Mills <bcmills@google.com>2020-09-29 10:23:07 -0400
committerBryan C. Mills <bcmills@google.com>2020-09-30 18:07:33 +0000
commitf811663f0483b05bb9986ce648bb653564217c6e (patch)
tree1bb226311c0bbeeb20023b69f42da56b25eeae09 /src
parentbb9b319228760f9e4b2517114b6eecc6fe0cef30 (diff)
downloadgo-f811663f0483b05bb9986ce648bb653564217c6e.tar.xz
cmd/go: test more commands in mod_build_info_error
For #26909 For #41688 Change-Id: I22f28d426ce499fce6f0f1295dbde425998042aa Reviewed-on: https://go-review.googlesource.com/c/go/+/258219 Trust: Bryan C. Mills <bcmills@google.com> Trust: Jay Conrod <jayconrod@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com> Reviewed-by: Michael Matloob <matloob@golang.org>
Diffstat (limited to 'src')
-rw-r--r--src/cmd/go/testdata/script/mod_build_info_err.txt15
1 files changed, 13 insertions, 2 deletions
diff --git a/src/cmd/go/testdata/script/mod_build_info_err.txt b/src/cmd/go/testdata/script/mod_build_info_err.txt
index a6853b5c86..4a6ee9e8bb 100644
--- a/src/cmd/go/testdata/script/mod_build_info_err.txt
+++ b/src/cmd/go/testdata/script/mod_build_info_err.txt
@@ -1,8 +1,19 @@
# This test verifies that line numbers are included in module import errors.
# Verifies golang.org/issue/34393.
-go list -e -deps -f '{{with .Error}}{{.Pos}}: {{.Err}}{{end}}' ./main
-stdout 'bad[/\\]bad.go:3:8: malformed import path "🐧.example.com/string": invalid char ''🐧'''
+go list -e -mod=mod -deps -f '{{with .Error}}{{.Pos}}: {{.Err}}{{end}}' ./main
+stdout '^bad[/\\]bad.go:3:8: malformed import path "🐧.example.com/string": invalid char ''🐧''$'
+
+# TODO(#26909): This should include an import stack.
+# (Today it includes only a file and line.)
+! go build ./main
+stderr '^bad[/\\]bad.go:3:8: malformed import path "🐧.example.com/string": invalid char ''🐧''$'
+
+# TODO(#41688): This should include a file and line, and report the reason for the error..
+# (Today it includes only an import stack, and does not indicate the actual problem.)
+! go get -d ./main
+stderr '^m/main imports\n\tm/bad imports\n\t🐧.example.com/string: import missing$'
+
-- go.mod --
module m