diff options
| author | Ian Lance Taylor <iant@golang.org> | 2016-04-22 10:17:06 -0700 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2016-04-22 20:33:22 +0000 |
| commit | eee20b7244586da70b2bca6fe6346da7dac6be78 (patch) | |
| tree | a1779cd6694a8ecfea63ca20e04c87a3d2998582 /src | |
| parent | f71a13da93b6ec2da88e2568deacdb6ef002b36c (diff) | |
| download | go-eee20b7244586da70b2bca6fe6346da7dac6be78.tar.xz | |
cmd/dist: skip misc/cgo/test with internal linking on ppc64le
CL 22372 changed ppc64le to use normal cgo initialization on ppc64le.
Doing this uncovered a cmd/link error using internal linking.
Opened issue 15409 for the problem. This CL disables the test.
Update #15409.
Change-Id: Ia1bb6b874c1b5a4df1a0436c8841c145142c30f7
Reviewed-on: https://go-review.googlesource.com/22379
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/dist/test.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 9a9cf2d7e4..11c22f4fd3 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -725,8 +725,10 @@ func (t *tester) cgoTest(dt *distTest) error { cmd := t.addCmd(dt, "misc/cgo/test", "go", "test", t.tags(), "-ldflags", "-linkmode=auto") cmd.Env = env - if t.gohostos != "dragonfly" { + if t.gohostos != "dragonfly" && t.gohostarch != "ppc64le" { // linkmode=internal fails on dragonfly since errno is a TLS relocation. + // linkmode=internal fails on ppc64le because cmd/link doesn't + // handle the TOC correctly (issue 15409). cmd := t.addCmd(dt, "misc/cgo/test", "go", "test", "-ldflags", "-linkmode=internal") cmd.Env = env } |