diff options
| author | Robert Griesemer <gri@golang.org> | 2023-05-23 16:45:37 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-05-24 01:57:07 +0000 |
| commit | e7a9ca0a53db4b4f357b5d3caaef65e44ce08a90 (patch) | |
| tree | 736c52bac1ce2454eff6ae549160ca22bbd759f5 /src | |
| parent | cf624a612743d1ff9d010072f978bd4417c0522d (diff) | |
| download | go-e7a9ca0a53db4b4f357b5d3caaef65e44ce08a90.tar.xz | |
cmd/compile: enable printing of error URLs by default
Change-Id: Ib4094c70b8aa5e818f9f017c59d464d4c178169d
Reviewed-on: https://go-review.googlesource.com/c/go/+/497716
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/compile/internal/base/flag.go | 1 | ||||
| -rw-r--r-- | src/cmd/internal/testdir/testdir_test.go | 6 |
2 files changed, 4 insertions, 3 deletions
diff --git a/src/cmd/compile/internal/base/flag.go b/src/cmd/compile/internal/base/flag.go index 753a60ae1e..a5441ffac2 100644 --- a/src/cmd/compile/internal/base/flag.go +++ b/src/cmd/compile/internal/base/flag.go @@ -164,6 +164,7 @@ func ParseFlags() { Flag.LinkShared = &Ctxt.Flag_linkshared Flag.Shared = &Ctxt.Flag_shared Flag.WB = true + Flag.ErrorURL = true Debug.ConcurrentOk = true Debug.InlFuncsWithClosures = 1 diff --git a/src/cmd/internal/testdir/testdir_test.go b/src/cmd/internal/testdir/testdir_test.go index c86cc20a9c..d9f78f2f6a 100644 --- a/src/cmd/internal/testdir/testdir_test.go +++ b/src/cmd/internal/testdir/testdir_test.go @@ -184,7 +184,7 @@ func compileInDir(runcmd runCmd, dir string, flags []string, importcfg string, p if importcfg == "" { importcfg = stdlibImportcfgFile() } - cmd := []string{goTool, "tool", "compile", "-e", "-D", "test", "-importcfg=" + importcfg} + cmd := []string{goTool, "tool", "compile", "-e", "-D", "test", "-errorurl=false", "-importcfg=" + importcfg} if pkgname == "main" { cmd = append(cmd, "-p=main") } else { @@ -201,7 +201,7 @@ func compileInDir(runcmd runCmd, dir string, flags []string, importcfg string, p return runcmd(cmd...) } -var stdlibImportcfgStringOnce sync.Once // TODO(#56102): Use sync.OnceValue once availabe. Also below. +var stdlibImportcfgStringOnce sync.Once // TODO(#56102): Use sync.OnceValue once available. Also below. var stdlibImportcfgString string func stdlibImportcfg() string { @@ -745,7 +745,7 @@ func (t test) run() error { // Fail if wantError is true and compilation was successful and vice versa. // Match errors produced by gc against errors in comments. // TODO(gri) remove need for -C (disable printing of columns in error messages) - cmdline := []string{goTool, "tool", "compile", "-p=p", "-d=panic", "-C", "-e", "-importcfg=" + stdlibImportcfgFile(), "-o", "a.o"} + cmdline := []string{goTool, "tool", "compile", "-p=p", "-d=panic", "-C", "-e", "-errorurl=false", "-importcfg=" + stdlibImportcfgFile(), "-o", "a.o"} // No need to add -dynlink even if linkshared if we're just checking for errors... cmdline = append(cmdline, flags...) cmdline = append(cmdline, long) |