diff options
| author | Tarmigan Casebolt <tarmigan@gmail.com> | 2015-08-23 19:51:31 -0700 |
|---|---|---|
| committer | Minux Ma <minux@golang.org> | 2015-09-20 02:55:16 +0000 |
| commit | e643dc79d4d9c9d6cd680351a8d3aab5de531903 (patch) | |
| tree | 79f4bb5f3a0e6e739ef7e154d7bbfacb79f75ce1 /src | |
| parent | 9172a1b5738bf55b4d2b6f045cf40cae24c081f1 (diff) | |
| download | go-e643dc79d4d9c9d6cd680351a8d3aab5de531903.tar.xz | |
net: check 'ok' return in dnsmsg when initially packing rr.Header()
In the present code, there is no way for ok to ever return false, but
it still a good idea to check it.
Change-Id: I8f360018b33a5d85dabbbbec0f89ffc81f77ecbb
Reviewed-on: https://go-review.googlesource.com/13956
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/net/dnsmsg.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/net/dnsmsg.go b/src/net/dnsmsg.go index 6ecaa94823..93078fe849 100644 --- a/src/net/dnsmsg.go +++ b/src/net/dnsmsg.go @@ -691,6 +691,9 @@ func packRR(rr dnsRR, msg []byte, off int) (off2 int, ok bool) { // off1 is end of header // off2 is end of rr off1, ok = packStruct(rr.Header(), msg, off) + if !ok { + return len(msg), false + } off2, ok = packStruct(rr, msg, off) if !ok { return len(msg), false |