diff options
| author | Mikio Hara <mikioh.mikioh@gmail.com> | 2016-11-16 13:35:59 +0900 |
|---|---|---|
| committer | Mikio Hara <mikioh.mikioh@gmail.com> | 2016-11-16 05:51:18 +0000 |
| commit | d338f2e1470227afcadde977f2f2ab07d65088db (patch) | |
| tree | e55cd5d7cdf6d2bed15cd048fa14fc19a1064eb3 /src | |
| parent | 1f605175b0044d69ac2364c24f515344c9866fd6 (diff) | |
| download | go-d338f2e1470227afcadde977f2f2ab07d65088db.tar.xz | |
net: don't run TestTCPBig unconditionally
The test requires tons of memory and results various failures, mainly
runtime errors and process termination by SIGKILL, caused by resource
exhaustion when the node under test doesn't have much resources.
This change makes use of -tcpbig flag to enable the test.
Change-Id: Id53fa5d88543e2e60ca9bb4f55a1914ccca844e1
Reviewed-on: https://go-review.googlesource.com/33254
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/net/main_test.go | 2 | ||||
| -rw-r--r-- | src/net/tcpsock_test.go | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/src/net/main_test.go b/src/net/main_test.go index 7573ded93b..28a8ff66d6 100644 --- a/src/net/main_test.go +++ b/src/net/main_test.go @@ -24,6 +24,8 @@ var ( ) var ( + testTCPBig = flag.Bool("tcpbig", false, "whether to test massive size of data per read or write call on TCP connection") + testDNSFlood = flag.Bool("dnsflood", false, "whether to test DNS query flooding") // If external IPv4 connectivity exists, we can try dialing diff --git a/src/net/tcpsock_test.go b/src/net/tcpsock_test.go index 7c8610d32b..573e834911 100644 --- a/src/net/tcpsock_test.go +++ b/src/net/tcpsock_test.go @@ -670,8 +670,8 @@ func TestTCPSelfConnect(t *testing.T) { // Test that >32-bit reads work on 64-bit systems. // On 32-bit systems this tests that maxint reads work. func TestTCPBig(t *testing.T) { - if testing.Short() { - t.Skip("skipping test in short mode") + if !*testTCPBig { + t.Skip("test disabled; use -tcpbig to enable") } for _, writev := range []bool{false, true} { |