diff options
| author | Josh Bleecher Snyder <josharian@gmail.com> | 2018-06-03 07:26:16 -0700 |
|---|---|---|
| committer | Robert Griesemer <gri@golang.org> | 2018-06-04 17:32:17 +0000 |
| commit | cf2c2ea89d09d486bb018b1817c5874388038c3a (patch) | |
| tree | 9473c8b23c15ceb658df25a9b80b20b40a64d453 /src | |
| parent | ef9217e7bd9c854e4f8d2d79ff8aec550130cbc4 (diff) | |
| download | go-cf2c2ea89d09d486bb018b1817c5874388038c3a.tar.xz | |
text/tabwriter: fix BenchmarkPyramid and BenchmarkRagged again
These were added in CL 106979. I got them wrong.
They were fixed in CL 111643. They were still wrong.
Hopefully this change will be the last fix.
With this fix, CL 106979 is allocation-neutral for BenchmarkRagged.
The performance results for BenchmarkPyramid reported in CL 111643 stand.
Change-Id: Id6a522e6602e5df31f504adf5a3bec9969c18649
Reviewed-on: https://go-review.googlesource.com/116015
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/text/tabwriter/tabwriter_test.go | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/text/tabwriter/tabwriter_test.go b/src/text/tabwriter/tabwriter_test.go index 2dddd5233c..07bae0ca0b 100644 --- a/src/text/tabwriter/tabwriter_test.go +++ b/src/text/tabwriter/tabwriter_test.go @@ -693,7 +693,6 @@ func BenchmarkPyramid(b *testing.B) { for _, x := range [...]int{10, 100, 1000} { // Build a line with x cells. line := bytes.Repeat([]byte("a\t"), x) - line = append(line, '\n') b.Run(fmt.Sprintf("%d", x), func(b *testing.B) { b.ReportAllocs() for i := 0; i < b.N; i++ { @@ -712,9 +711,8 @@ func BenchmarkPyramid(b *testing.B) { func BenchmarkRagged(b *testing.B) { var lines [8][]byte for i, w := range [8]int{6, 2, 9, 5, 5, 7, 3, 8} { - // Build a line with x cells. + // Build a line with w cells. lines[i] = bytes.Repeat([]byte("a\t"), w) - lines[i] = append(lines[i], '\n') } for _, h := range [...]int{10, 100, 1000} { b.Run(fmt.Sprintf("%d", h), func(b *testing.B) { |