diff options
| author | Quan Tong <quantonganh@gmail.com> | 2023-10-19 11:44:32 +0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-10-20 17:54:46 +0000 |
| commit | c75a617af02fcfa53effed30803f2a96388680d5 (patch) | |
| tree | 965e519dad56eaadbf286621093518eabaa12ede /src | |
| parent | 2968f5623c71d0e8e7be6e117939c5f585bb0620 (diff) | |
| download | go-c75a617af02fcfa53effed30803f2a96388680d5.tar.xz | |
cmd/go/internal/work: set Incomplete to true if there is an error
Fixes #57724
Change-Id: I3d419985ff41d5ee93bb56d8c7ca5cd1d7231920
Reviewed-on: https://go-review.googlesource.com/c/go/+/536418
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/go/internal/work/exec.go | 1 | ||||
| -rw-r--r-- | src/cmd/go/testdata/script/list_export_e.txt | 4 |
2 files changed, 5 insertions, 0 deletions
diff --git a/src/cmd/go/internal/work/exec.go b/src/cmd/go/internal/work/exec.go index 4f4fb704b8..ecad324886 100644 --- a/src/cmd/go/internal/work/exec.go +++ b/src/cmd/go/internal/work/exec.go @@ -164,6 +164,7 @@ func (b *Builder) Do(ctx context.Context, root *Action) { if b.AllowErrors && a.Package != nil { if a.Package.Error == nil { a.Package.Error = &load.PackageError{Err: err} + a.Package.Incomplete = true } } else { var ipe load.ImportPathError diff --git a/src/cmd/go/testdata/script/list_export_e.txt b/src/cmd/go/testdata/script/list_export_e.txt index 8e4c361fc4..6d5dd39f0b 100644 --- a/src/cmd/go/testdata/script/list_export_e.txt +++ b/src/cmd/go/testdata/script/list_export_e.txt @@ -6,6 +6,10 @@ go list -f '{{with .Error}}{{.}}{{end}}' -e -export ./... ! stderr '.' stdout '^# example.com/p2\np2'${/}'main\.go:7:.*' +go list -export -e -f '{{.ImportPath}} -- {{.Incomplete}} -- {{.Error}}' ./... +stdout 'example.com/p1 -- false -- <nil>' +stdout 'example.com/p2 -- true -- # example.com/p2' + go list -e -export -json=Error ./... stdout '"Err": "# example.com/p2' |