diff options
| author | Nevkontakte <aleks@nevkontakte.com> | 2021-10-23 14:02:25 +0000 |
|---|---|---|
| committer | Damien Neil <dneil@google.com> | 2021-11-05 21:34:10 +0000 |
| commit | bb53fd740c599dd72c2abdab045ca34a9395ea13 (patch) | |
| tree | 8e72db044ad0a8d75953505bda388067d56dc585 /src | |
| parent | 75952abc6a8a8ad09e6bb1966c66b9a68b5d6c4e (diff) | |
| download | go-bb53fd740c599dd72c2abdab045ca34a9395ea13.tar.xz | |
net/http: adjust a substring which matches "uninteresting" goroutine
This change allows the check to pass unmodified under GopherJS, which
stack traces are formatted differently (due to being generated by
NodeJS). There are no other functions named `interestingGoroutines` in
the standard library, so it's very unlikely to create false negatives,
and will allow reduce the number of overlays GopherJS needs to maintain.
Change-Id: I925594c6c313ca35805811f240c8528241950547
GitHub-Last-Rev: 26b32efb225c1ee85de0a51968c31b1a58d56f92
GitHub-Pull-Request: golang/go#49128
Reviewed-on: https://go-review.googlesource.com/c/go/+/358154
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Damien Neil <dneil@google.com>
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/net/http/main_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/net/http/main_test.go b/src/net/http/main_test.go index 632a308a5c..27872b4e7a 100644 --- a/src/net/http/main_test.go +++ b/src/net/http/main_test.go @@ -43,7 +43,7 @@ func interestingGoroutines() (gs []string) { // These only show up with GOTRACEBACK=2; Issue 5005 (comment 28) strings.Contains(stack, "runtime.goexit") || strings.Contains(stack, "created by runtime.gc") || - strings.Contains(stack, "net/http_test.interestingGoroutines") || + strings.Contains(stack, "interestingGoroutines") || strings.Contains(stack, "runtime.MHeap_Scavenger") { continue } |