diff options
| author | Emmanuel Odeke <emm.odeke@gmail.com> | 2015-12-04 17:21:08 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2015-12-09 01:00:44 +0000 |
| commit | b220d41666aa276c72fd94f82e8ec91f146d2e49 (patch) | |
| tree | edaf406ae5a9bf2eb7383412eae0405e8aa65f58 /src | |
| parent | 5d7dc23ec5fe47eb0520a2542c05383c8854c0af (diff) | |
| download | go-b220d41666aa276c72fd94f82e8ec91f146d2e49.tar.xz | |
net/http: sniffTest for 5953 set in http2 mode
Change-Id: I345b6ea7024a1c85c805b2d2e22f9f79aeca5816
Reviewed-on: https://go-review.googlesource.com/17462
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/net/http/sniff_test.go | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/src/net/http/sniff_test.go b/src/net/http/sniff_test.go index 170de7314c..a776261cc1 100644 --- a/src/net/http/sniff_test.go +++ b/src/net/http/sniff_test.go @@ -11,7 +11,6 @@ import ( "io/ioutil" "log" . "net/http" - "net/http/httptest" "reflect" "strconv" "strings" @@ -88,15 +87,18 @@ func testServerContentType(t *testing.T, h2 bool) { // Issue 5953: shouldn't sniff if the handler set a Content-Type header, // even if it's the empty string. -func TestServerIssue5953(t *testing.T) { +func TestServerIssue5953_h1(t *testing.T) { testServerIssue5953(t, false) } +func TestServerIssue5953_h2(t *testing.T) { testServerIssue5953(t, true) } + +func testServerIssue5953(t *testing.T, h2 bool) { defer afterTest(t) - ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { + cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { w.Header()["Content-Type"] = []string{""} fmt.Fprintf(w, "<html><head></head><body>hi</body></html>") })) - defer ts.Close() + defer cst.close() - resp, err := Get(ts.URL) + resp, err := cst.c.Get(cst.ts.URL) if err != nil { t.Fatal(err) } |