diff options
| author | Daniel Martà <mvdan@mvdan.cc> | 2017-03-10 17:15:46 +0000 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2017-03-14 21:46:31 +0000 |
| commit | a9824cd47c1927ffc4eca040d60aecaa26130329 (patch) | |
| tree | 6dca9d4b8ba59f296165bc41ec3d66b0f398ade7 /src | |
| parent | 723ba180b39969463f3644bac6422f0f81da26ea (diff) | |
| download | go-a9824cd47c1927ffc4eca040d60aecaa26130329.tar.xz | |
*.bash: always use the same string equality operator
POSIX Shell only supports = to compare variables inside '[' tests. But
this is Bash, where == is an alias for =. In practice they're the same,
but the current form is inconsisnent and breaks POSIX for no good
reason.
Change-Id: I38fa7a5a90658dc51acc2acd143049e510424ed8
Reviewed-on: https://go-review.googlesource.com/38031
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src')
| -rwxr-xr-x | src/iostest.bash | 6 | ||||
| -rwxr-xr-x | src/make.bash | 4 | ||||
| -rwxr-xr-x | src/run.bash | 6 |
3 files changed, 8 insertions, 8 deletions
diff --git a/src/iostest.bash b/src/iostest.bash index 5e09894852..595b675744 100755 --- a/src/iostest.bash +++ b/src/iostest.bash @@ -24,11 +24,11 @@ if [ "$GOARCH" != "arm" ] && [ "$GOARCH" != "arm64" ]; then echo "iostest.bash requires GOARCH=arm or GOARCH=arm64, got GOARCH=$GOARCH" 1>&2 exit 1 fi -if [ "$GOARCH" == "arm" ]; then +if [ "$GOARCH" = "arm" ]; then export GOARM=7 fi -if [ "$1" == "-restart" ]; then +if [ "$1" = "-restart" ]; then # Reboot to make sure previous runs do not interfere with the current run. # It is reasonably easy for a bad program leave an iOS device in an # almost unusable state. @@ -60,7 +60,7 @@ GOOS=$GOHOSTOS GOARCH=$GOHOSTARCH go build \ -o ../bin/go_darwin_${GOARCH}_exec \ ../misc/ios/go_darwin_arm_exec.go -if [ "$GOIOS_DEV_ID" == "" ]; then +if [ "$GOIOS_DEV_ID" = "" ]; then echo "detecting iOS development identity" eval $(GOOS=$GOHOSTOS GOARCH=$GOHOSTARCH go run ../misc/ios/detect.go) fi diff --git a/src/make.bash b/src/make.bash index 6e6f96d5c7..71e75318f2 100755 --- a/src/make.bash +++ b/src/make.bash @@ -107,7 +107,7 @@ done # Test for debian/kFreeBSD. # cmd/dist will detect kFreeBSD as freebsd/$GOARCH, but we need to # disable cgo manually. -if [ "$(uname -s)" == "GNU/kFreeBSD" ]; then +if [ "$(uname -s)" = "GNU/kFreeBSD" ]; then export CGO_ENABLED=0 fi @@ -125,7 +125,7 @@ if [ ! -x "$GOROOT_BOOTSTRAP/bin/go" ]; then echo "Set \$GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4." >&2 exit 1 fi -if [ "$GOROOT_BOOTSTRAP" == "$GOROOT" ]; then +if [ "$GOROOT_BOOTSTRAP" = "$GOROOT" ]; then echo "ERROR: \$GOROOT_BOOTSTRAP must not be set to \$GOROOT" >&2 echo "Set \$GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4." >&2 exit 1 diff --git a/src/run.bash b/src/run.bash index c0029c51f4..1fde5f4610 100755 --- a/src/run.bash +++ b/src/run.bash @@ -36,12 +36,12 @@ ulimit -c 0 # This is a system misconfiguration and should be fixed on the # broken system, not "fixed" by ignoring the failure here. # See longer discussion on golang.org/issue/7381. -[ "$(ulimit -H -n)" == "unlimited" ] || ulimit -S -n $(ulimit -H -n) -[ "$(ulimit -H -d)" == "unlimited" ] || ulimit -S -d $(ulimit -H -d) +[ "$(ulimit -H -n)" = "unlimited" ] || ulimit -S -n $(ulimit -H -n) +[ "$(ulimit -H -d)" = "unlimited" ] || ulimit -S -d $(ulimit -H -d) # Thread count limit on NetBSD 7. if ulimit -T &> /dev/null; then - [ "$(ulimit -H -T)" == "unlimited" ] || ulimit -S -T $(ulimit -H -T) + [ "$(ulimit -H -T)" = "unlimited" ] || ulimit -S -T $(ulimit -H -T) fi exec go tool dist test -rebuild "$@" |