diff options
| author | Bryan C. Mills <bcmills@google.com> | 2019-11-05 12:13:48 -0500 |
|---|---|---|
| committer | Bryan C. Mills <bcmills@google.com> | 2019-11-05 18:02:45 +0000 |
| commit | 95149147d86ad33a82a5d0115bbb9c623cd7cade (patch) | |
| tree | 285e61c189de9d5fdbb48ee7e83b1fa802201371 /src | |
| parent | 0994cc1af63ce084712d6257f9993f9cefa2d441 (diff) | |
| download | go-95149147d86ad33a82a5d0115bbb9c623cd7cade.tar.xz | |
cmd/compile: do not skip TestFormats on short builders
TestFormats adds ~3s of running time to the test, which may be
slightly annoying in an edit/compile/test cycle but is negligible in a
TryBot run.
The test keeps regressing in the longtest builders, requiring a manual
fix. Instead, run it even in short mode on the builders, so that
TryBot runs will detect regressions ahead of time.
Updates #34907
Updates #33915
Updates #28621
Change-Id: I6f9bf0f2ca929a743438310b86d85d8673c720bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/205440
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/compile/fmt_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/compile/fmt_test.go b/src/cmd/compile/fmt_test.go index 51079e3dcf..f1af6473c7 100644 --- a/src/cmd/compile/fmt_test.go +++ b/src/cmd/compile/fmt_test.go @@ -83,7 +83,7 @@ type File struct { } func TestFormats(t *testing.T) { - if testing.Short() { + if testing.Short() && testenv.Builder() == "" { t.Skip("Skipping in short mode") } testenv.MustHaveGoBuild(t) // more restrictive than necessary, but that's ok |