diff options
| author | guoguangwu <guoguangwug@gmail.com> | 2024-04-15 02:11:58 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-04-15 16:20:39 +0000 |
| commit | 8e987fadb57fa1fc98975ca2fcb3a4751f7f55ff (patch) | |
| tree | f39661c40e8be59e2d1d940f48887fbf899d4939 /src | |
| parent | c71d2a8d8fcb50ed8ab0e1c4af211a0dcea16a75 (diff) | |
| download | go-8e987fadb57fa1fc98975ca2fcb3a4751f7f55ff.tar.xz | |
cmd/pprof: close resp body after the profile.Parse is called
Change-Id: I5bccef3c46072e388bfe9985e70745853f673a42
GitHub-Last-Rev: adee7b9f7fa21c3ee5561b8233bbfe94168e45ed
GitHub-Pull-Request: golang/go#66829
Reviewed-on: https://go-review.googlesource.com/c/go/+/578875
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/pprof/pprof.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/pprof/pprof.go b/src/cmd/pprof/pprof.go index bc1a4cf9f7..d4db9df285 100644 --- a/src/cmd/pprof/pprof.go +++ b/src/cmd/pprof/pprof.go @@ -84,8 +84,8 @@ func getProfile(source string, timeout time.Duration) (*profile.Profile, error) if err != nil { return nil, err } + defer resp.Body.Close() if resp.StatusCode != http.StatusOK { - defer resp.Body.Close() return nil, statusCodeError(resp) } return profile.Parse(resp.Body) |