diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2019-09-16 11:28:05 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2019-09-16 19:43:54 +0000 |
| commit | 7f907b9ceecfecb6dfe03878490bd3ae97ba8f2f (patch) | |
| tree | 58f52122fa8e6217d65f994c5207bca264ec4954 /src | |
| parent | c2facbe93705530a4b4aea70da544a7d645ea288 (diff) | |
| download | go-7f907b9ceecfecb6dfe03878490bd3ae97ba8f2f.tar.xz | |
cmd/compile: require -lang=go1.14 for overlapping interfaces
Support for overlapping interfaces is a new (proposed) Go language
feature to be supported in Go 1.14, so it shouldn't be supported under
-lang=go1.13 or earlier.
Fixes #34329.
Change-Id: I5fea5716b7d135476980bc40b4f6e8c611b67735
Reviewed-on: https://go-review.googlesource.com/c/go/+/195678
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/compile/internal/gc/align.go | 2 | ||||
| -rw-r--r-- | src/go/types/stdlib_test.go | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/gc/align.go b/src/cmd/compile/internal/gc/align.go index d6251adc7a..bd6176e479 100644 --- a/src/cmd/compile/internal/gc/align.go +++ b/src/cmd/compile/internal/gc/align.go @@ -34,7 +34,7 @@ func expandiface(t *types.Type) { switch prev := seen[m.Sym]; { case prev == nil: seen[m.Sym] = m - case !explicit && types.Identical(m.Type, prev.Type): + case langSupported(1, 14) && !explicit && types.Identical(m.Type, prev.Type): return default: yyerrorl(m.Pos, "duplicate method %s", m.Sym.Name) diff --git a/src/go/types/stdlib_test.go b/src/go/types/stdlib_test.go index 771f54d3f1..a3cbe95b3a 100644 --- a/src/go/types/stdlib_test.go +++ b/src/go/types/stdlib_test.go @@ -181,6 +181,7 @@ func TestStdFixed(t *testing.T) { "issue25507.go", // go/types does not have constraints on stack size "issue20780.go", // go/types does not have constraints on stack size "issue31747.go", // go/types does not have constraints on language level (-lang=go1.12) (see #31793) + "issue34329.go", // go/types does not have constraints on language level (-lang=go1.13) (see #31793) ) } |