diff options
| author | Alberto Donizetti <alb.donizetti@gmail.com> | 2018-05-02 12:58:18 +0200 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2018-05-02 14:41:32 +0000 |
| commit | 7e960d06d202d6bfc63fbd6b2528feb4f2b77b4e (patch) | |
| tree | 16eef5b60db58ed531e8b04bbd51deb39bf0168d /src | |
| parent | 500d79c410f8e9ad762ba318a0a4b05d0d4d1751 (diff) | |
| download | go-7e960d06d202d6bfc63fbd6b2528feb4f2b77b4e.tar.xz | |
cmd/go: enable upx compression test on linux/386
We have a cmd/go test ensuring that upx (an executable
packer/compressor) works on linux/amd64 Go binaries.
The linux-386-sid builder is built from the same dockerfile as the
linux-amd64-sid builder, so upx should also already be available on
the former. Since upx support 386 executables, we can enable the upx
test for GOARCH=386.
Updates #16706
Change-Id: I94e19ff1001de83a0386754a5104a377c72fb221
Reviewed-on: https://go-review.googlesource.com/110817
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/go/go_test.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index 19e4116eb3..2b2e17a71a 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -5037,7 +5037,8 @@ func TestWrongGOOSErrorBeforeLoadError(t *testing.T) { } func TestUpxCompression(t *testing.T) { - if runtime.GOOS != "linux" || runtime.GOARCH != "amd64" { + if runtime.GOOS != "linux" || + (runtime.GOARCH != "amd64" && runtime.GOARCH != "386") { t.Skipf("skipping upx test on %s/%s", runtime.GOOS, runtime.GOARCH) } |
