diff options
| author | Rob Pike <r@golang.org> | 2019-11-07 13:57:19 +1100 |
|---|---|---|
| committer | Rob Pike <r@golang.org> | 2019-11-07 08:25:32 +0000 |
| commit | 7a2baa9c48601e65bc8c8ed99d57a0d214b779ef (patch) | |
| tree | b502cddbabf1eee6d2f09e6c31c4ca63ddda25d4 /src | |
| parent | f5949b60676bc253aca36fea91f9542e6d517f9e (diff) | |
| download | go-7a2baa9c48601e65bc8c8ed99d57a0d214b779ef.tar.xz | |
cmd/doc: don't bother checking validity of symbols at top level
No need to check as pieces further down do so anyway:
% go doc '&&.%$^'
doc: symbol && is not a type in package fmt installed in "fmt"
exit status 1
%
Removing this check allows 'go doc sort.interface' or 'go doc
types.type' to discover sort.Interface and go/types.Type.
Easily
Fixes #34656.
Change-Id: I84352e83dd7f91a232f45a44d1a52f019a1a9a06
Reviewed-on: https://go-review.googlesource.com/c/go/+/205778
Reviewed-by: Caleb Spare <cespare@gmail.com>
Reviewed-by: Daniel Martà <mvdan@mvdan.cc>
Run-TryBot: Daniel Martà <mvdan@mvdan.cc>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/doc/main.go | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/cmd/doc/main.go b/src/cmd/doc/main.go index 43144d9f22..86259e5f1f 100644 --- a/src/cmd/doc/main.go +++ b/src/cmd/doc/main.go @@ -358,17 +358,11 @@ func parseSymbol(str string) (symbol, method string) { case 1: case 2: method = elem[1] - if !token.IsIdentifier(method) { - log.Fatalf("invalid identifier %q", method) - } default: log.Printf("too many periods in symbol specification") usage() } symbol = elem[0] - if !token.IsIdentifier(symbol) { - log.Fatalf("invalid identifier %q", symbol) - } return } |