diff options
| author | Robert Griesemer <gri@golang.org> | 2017-06-28 15:04:47 -0700 |
|---|---|---|
| committer | Robert Griesemer <gri@golang.org> | 2017-06-28 22:20:15 +0000 |
| commit | 773504aee53eb8229f5e78db36258cc6bb389199 (patch) | |
| tree | 343eff9e824b66d83d6abe523bd9492fc06689f0 /src | |
| parent | 9745e88b224d517018ba8421972a0de5dd1c231c (diff) | |
| download | go-773504aee53eb8229f5e78db36258cc6bb389199.tar.xz | |
go/importer: don't return packages that are not fully type-checked
Fixes #20837.
Change-Id: I266519c26c8849da267b77e11abe7734d8275112
Reviewed-on: https://go-review.googlesource.com/47074
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/go/internal/srcimporter/srcimporter.go | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/go/internal/srcimporter/srcimporter.go b/src/go/internal/srcimporter/srcimporter.go index f259493fc7..50cf361dbb 100644 --- a/src/go/internal/srcimporter/srcimporter.go +++ b/src/go/internal/srcimporter/srcimporter.go @@ -136,8 +136,11 @@ func (p *Importer) ImportFrom(path, srcDir string, mode types.ImportMode) (*type } pkg, err = conf.Check(bp.ImportPath, p.fset, files, nil) if err != nil { - // return (possibly nil or incomplete) package with error (see #16088) - return pkg, fmt.Errorf("type-checking package %q failed (%v)", bp.ImportPath, err) + // Type-checking stops after the first error (types.Config.Error is not set), + // so the returned package is very likely incomplete. Don't return it since + // we don't know its condition: It's very likely unsafe to use and it's also + // not added to p.packages which may cause further problems (issue #20837). + return nil, fmt.Errorf("type-checking package %q failed (%v)", bp.ImportPath, err) } p.packages[bp.ImportPath] = pkg |