diff options
| author | Keith Randall <keithr@alum.mit.edu> | 2019-05-16 16:16:26 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2019-05-17 03:46:38 +0000 |
| commit | 6c842cc610bff3e025236dfe4ececbdf91aa66e3 (patch) | |
| tree | 7d6d40e1c10c501aa596fd085866b788bc9dc306 /src | |
| parent | 97ecc4321ec3069d405c04cb2dc3132b39ef732e (diff) | |
| download | go-6c842cc610bff3e025236dfe4ececbdf91aa66e3.tar.xz | |
cmd/compile: mention issue 28603 when discussing where inline marks go
Update #28603
Change-Id: I8bdbea57b3661e15dcc760d27252b794daa476db
Reviewed-on: https://go-review.googlesource.com/c/go/+/177697
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/compile/internal/gc/inl.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cmd/compile/internal/gc/inl.go b/src/cmd/compile/internal/gc/inl.go index addba98e3e..b41b8cb1a4 100644 --- a/src/cmd/compile/internal/gc/inl.go +++ b/src/cmd/compile/internal/gc/inl.go @@ -1046,10 +1046,11 @@ func mkinlcall(n, fn *Node, maxCost int32) *Node { } newIndex := Ctxt.InlTree.Add(parent, n.Pos, fn.Sym.Linksym()) - // Add a inline mark just before the inlined body. + // Add an inline mark just before the inlined body. // This mark is inline in the code so that it's a reasonable spot // to put a breakpoint. Not sure if that's really necessary or not // (in which case it could go at the end of the function instead). + // Note issue 28603. inlMark := nod(OINLMARK, nil, nil) inlMark.Pos = n.Pos.WithIsStmt() inlMark.Xoffset = int64(newIndex) |