diff options
| author | Josh Bleecher Snyder <josharian@gmail.com> | 2016-11-02 17:55:29 -0700 |
|---|---|---|
| committer | Josh Bleecher Snyder <josharian@gmail.com> | 2016-11-03 01:07:08 +0000 |
| commit | 66504485ebd8d7a75b68c025cc15835b016a1ae4 (patch) | |
| tree | 6734eda81d0d6d6bdb68d14b062055244f281938 /src | |
| parent | 827f2accc1a25b77003303d3c35db5fc054bf8f1 (diff) | |
| download | go-66504485ebd8d7a75b68c025cc15835b016a1ae4.tar.xz | |
cmd/compile/internal/gc: make tests run faster
TestAssembly takes 20s on my machine,
which is too slow for normal operation.
Marking as -short has its dangers (#17472),
but hopefully we'll soon have a builder for that.
All the SSA tests are hermetic and not time sensitive
and can thus be run in parallel.
Reduces the cmd/compile/internal/gc test time during
all.bash on my laptop from 42s to 7s.
Updates #17751
Change-Id: Idd876421db23b9fa3475e8a9b3355a5dc92a5a29
Reviewed-on: https://go-review.googlesource.com/32585
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/compile/internal/gc/asm_test.go | 3 | ||||
| -rw-r--r-- | src/cmd/compile/internal/gc/ssa_test.go | 2 |
2 files changed, 5 insertions, 0 deletions
diff --git a/src/cmd/compile/internal/gc/asm_test.go b/src/cmd/compile/internal/gc/asm_test.go index b0635cd308..58cdb9da7d 100644 --- a/src/cmd/compile/internal/gc/asm_test.go +++ b/src/cmd/compile/internal/gc/asm_test.go @@ -21,6 +21,9 @@ import ( // TestAssembly checks to make sure the assembly generated for // functions contains certain expected instructions. func TestAssembly(t *testing.T) { + if testing.Short() { + t.Skip("slow test; skipping") + } testenv.MustHaveGoBuild(t) if runtime.GOOS == "windows" { // TODO: remove if we can get "go tool compile -S" to work on windows. diff --git a/src/cmd/compile/internal/gc/ssa_test.go b/src/cmd/compile/internal/gc/ssa_test.go index debdc4386b..1aebd90311 100644 --- a/src/cmd/compile/internal/gc/ssa_test.go +++ b/src/cmd/compile/internal/gc/ssa_test.go @@ -16,9 +16,11 @@ import ( // TODO: move all these tests elsewhere? // Perhaps teach test/run.go how to run them with a new action verb. func runTest(t *testing.T, filename string) { + t.Parallel() doTest(t, filename, "run") } func buildTest(t *testing.T, filename string) { + t.Parallel() doTest(t, filename, "build") } func doTest(t *testing.T, filename string, kind string) { |