aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorIan Lance Taylor <iant@golang.org>2018-06-29 14:38:56 -0700
committerIan Lance Taylor <iant@golang.org>2018-07-06 22:39:14 +0000
commit616da5da94aad1de2464e67e71d8eb1f4292f445 (patch)
tree5682591bb755991dc4d4b71f42e609f4526ec6db /src
parent8d5fd871d79bd62b04bfadb3b7be0a896029e80c (diff)
downloadgo-616da5da94aad1de2464e67e71d8eb1f4292f445.tar.xz
os: increase directory reading block size on Unix systems
Reportedly CIFS on RHEL 7 can fail to report files if directories are read in 4K increments. While this seems to be a CIFS or RHEL bug, reportedly CIFS does not return more than 5760 bytes in a block, so reading in 8K increments should hide the problem from users with minimal cost. Fixes #24015 Change-Id: Iaf9f00ffe338d379c819ed9edcd4cc9834e3b0f7 Reviewed-on: https://go-review.googlesource.com/121756 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src')
-rw-r--r--src/os/dir_unix.go3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/os/dir_unix.go b/src/os/dir_unix.go
index 09c3d2eb61..79d61c783f 100644
--- a/src/os/dir_unix.go
+++ b/src/os/dir_unix.go
@@ -13,7 +13,8 @@ import (
)
const (
- blockSize = 4096
+ // More than 5760 to work around https://golang.org/issue/24015.
+ blockSize = 8192
)
func (f *File) readdir(n int) (fi []FileInfo, err error) {