diff options
| author | Zeke Lu <lvzecai@gmail.com> | 2022-08-27 02:42:52 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-08-29 19:38:15 +0000 |
| commit | 5cfeaed4dec52c8edb3f33bb9cf8ec98d846c50b (patch) | |
| tree | 1d373de00b6ed7b939dc6878e7934e46230698ed /src | |
| parent | 4029124cf4e79ed6f1c6d4cc0a19331eeddd58a6 (diff) | |
| download | go-5cfeaed4dec52c8edb3f33bb9cf8ec98d846c50b.tar.xz | |
cmd/go/internal/modfetch: report error on failing to derive pseudo version from recent tag
The current implementation ignores the error when it tries to get
the recent tag on revisions, which results in incorrect pseudo
version (v0.0.0-) is derived.
Fixes #53935
Change-Id: I153d851eb913fb7e40051e194c92b9ca5bf0e906
GitHub-Last-Rev: 6ba1d90df56cc0f30557863aa8418c54885abb14
GitHub-Pull-Request: golang/go#54701
Reviewed-on: https://go-review.googlesource.com/c/go/+/426079
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/go/internal/modfetch/coderepo.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/cmd/go/internal/modfetch/coderepo.go b/src/cmd/go/internal/modfetch/coderepo.go index 8fb0035f8c..138c00da19 100644 --- a/src/cmd/go/internal/modfetch/coderepo.go +++ b/src/cmd/go/internal/modfetch/coderepo.go @@ -607,7 +607,10 @@ func (r *codeRepo) convert(info *codehost.RevInfo, statVers string) (*RevInfo, e return !isRetracted(v) } if pseudoBase == "" { - tag, _ := r.code.RecentTag(info.Name, tagPrefix, tagAllowed) + tag, err := r.code.RecentTag(info.Name, tagPrefix, tagAllowed) + if err != nil { + return nil, err + } if tag != "" { pseudoBase, _ = tagToVersion(tag) } |