diff options
| author | Robert Griesemer <gri@golang.org> | 2018-10-04 17:30:42 -0700 |
|---|---|---|
| committer | Robert Griesemer <gri@golang.org> | 2018-10-05 17:56:34 +0000 |
| commit | 497fd2c09ca4ed1d9f9d397aed71fce741e3588a (patch) | |
| tree | 2f8bb8ca0d5deef3b536c23a72fcb8992184141a /src | |
| parent | 71d40c492fa92e710f9a3b2f26881a86f877ae95 (diff) | |
| download | go-497fd2c09ca4ed1d9f9d397aed71fce741e3588a.tar.xz | |
go/types: remove a TODO, enable a test
1) Scopes do have a comment field for documentation (debugging output).
No need to do anything extra.
2) The testcase in expr3.src has ok error messages. Enabled.
Change-Id: Ic1a03bfec0a6a70d876aa6cfb936973abe58fe6c
Reviewed-on: https://go-review.googlesource.com/c/139902
Reviewed-by: Alan Donovan <adonovan@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/go/types/scope.go | 3 | ||||
| -rw-r--r-- | src/go/types/testdata/expr3.src | 2 |
2 files changed, 1 insertions, 4 deletions
diff --git a/src/go/types/scope.go b/src/go/types/scope.go index 839a60db2e..6cf5cc66f9 100644 --- a/src/go/types/scope.go +++ b/src/go/types/scope.go @@ -15,9 +15,6 @@ import ( "strings" ) -// TODO(gri) Provide scopes with a name or other mechanism so that -// objects can use that information for better printing. - // A Scope maintains a set of objects and links to its containing // (parent) and contained (children) scopes. Objects may be inserted // and looked up by name. The zero value for Scope is a ready-to-use diff --git a/src/go/types/testdata/expr3.src b/src/go/types/testdata/expr3.src index b4c8163324..d562f0b16b 100644 --- a/src/go/types/testdata/expr3.src +++ b/src/go/types/testdata/expr3.src @@ -497,7 +497,7 @@ func _calls() { f1(x ... /* ERROR "cannot use ..." */ ) f1(g0 /* ERROR "used as value" */ ()) f1(g1()) - // f1(g2()) // TODO(gri) missing position in error message + f1(g2 /* ERROR "cannot use g2" */ /* ERROR "too many arguments" */ ()) f2() /* ERROR "too few arguments" */ f2(3.14) /* ERROR "too few arguments" */ |