diff options
| author | Shenghou Ma <minux@golang.org> | 2016-11-28 20:31:18 -0500 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2016-11-30 03:36:02 +0000 |
| commit | 406d2fa2f3034974e94620bacf6c09bcabaf85fd (patch) | |
| tree | a99082c186dc9ea9ffc00c48f412c58f4bcdca42 /src | |
| parent | a745dc930e00a026aea6449ec0e790152eb4bcd4 (diff) | |
| download | go-406d2fa2f3034974e94620bacf6c09bcabaf85fd.tar.xz | |
net/http: fix test TestServeMuxHandlerRedirects
The code was intended to test that mux handler should redirect at
most once, but the added loop condition defeated that. Remove the
loop condition and document the intention better.
Fixes #18068.
Change-Id: I2a4ea041eae27168b45a09aa46e740ac03921594
Reviewed-on: https://go-review.googlesource.com/33654
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/net/http/serve_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/net/http/serve_test.go b/src/net/http/serve_test.go index 01a289fe97..593b1f3cdd 100644 --- a/src/net/http/serve_test.go +++ b/src/net/http/serve_test.go @@ -400,9 +400,9 @@ func TestServeMuxHandlerRedirects(t *testing.T) { } for _, tt := range serveMuxTests2 { - tries := 1 + tries := 1 // expect at most 1 redirection if redirOk is true. turl := tt.url - for tries > 0 { + for { u, e := url.Parse(turl) if e != nil { t.Fatal(e) |