diff options
| author | Aliaksandr Valialkin <valyala@gmail.com> | 2016-05-12 15:13:22 +0300 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2016-05-12 15:58:30 +0000 |
| commit | 376e6415402b4e62f96fb7f8f7a99d352aa9c1b3 (patch) | |
| tree | ec9c6e95883f4938f8d6141de6874fd4e476aa10 /src | |
| parent | a71584975dedd4f4975d65047ec7660191a49613 (diff) | |
| download | go-376e6415402b4e62f96fb7f8f7a99d352aa9c1b3.tar.xz | |
cmd: fixed certain vet warnings
Updates #11041
Change-Id: I7f2583d08f344d6622027c5e8a5de1f5d2f2881c
Reviewed-on: https://go-review.googlesource.com/23082
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/cover/cover.go | 2 | ||||
| -rw-r--r-- | src/cmd/dist/test.go | 2 | ||||
| -rw-r--r-- | src/cmd/internal/pprof/report/report.go | 4 | ||||
| -rw-r--r-- | src/cmd/link/internal/ld/objfile.go | 2 |
4 files changed, 6 insertions, 4 deletions
diff --git a/src/cmd/cover/cover.go b/src/cmd/cover/cover.go index 46495950e9..a9ed66eea0 100644 --- a/src/cmd/cover/cover.go +++ b/src/cmd/cover/cover.go @@ -388,7 +388,7 @@ func trimComments(file *ast.File, fset *token.FileSet) []*ast.CommentGroup { } } if list != nil { - comments = append(comments, &ast.CommentGroup{list}) + comments = append(comments, &ast.CommentGroup{List: list}) } } return comments diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 3d123c2c86..1a1f7d961b 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -699,7 +699,7 @@ func (t *tester) supportedBuildmode(mode string) bool { } return false default: - log.Fatal("internal error: unknown buildmode %s", mode) + log.Fatalf("internal error: unknown buildmode %s", mode) return false } } diff --git a/src/cmd/internal/pprof/report/report.go b/src/cmd/internal/pprof/report/report.go index c492b752b9..b11ad2ab36 100644 --- a/src/cmd/internal/pprof/report/report.go +++ b/src/cmd/internal/pprof/report/report.go @@ -205,7 +205,9 @@ func nodesPerSymbol(ns nodes, symbols []*objSymbol) map[*objSymbol]nodes { // offset to adjust the sample addresses. func annotateAssembly(insns []plugin.Inst, samples nodes, base uint64) nodes { // Add end marker to simplify printing loop. - insns = append(insns, plugin.Inst{^uint64(0), "", "", 0}) + insns = append(insns, plugin.Inst{ + Addr: ^uint64(0), + }) // Ensure samples are sorted by address. samples.sort(addressOrder) diff --git a/src/cmd/link/internal/ld/objfile.go b/src/cmd/link/internal/ld/objfile.go index d16431ddaa..be9832dc45 100644 --- a/src/cmd/link/internal/ld/objfile.go +++ b/src/cmd/link/internal/ld/objfile.go @@ -538,7 +538,7 @@ func (r *objReader) readSymName() string { origName = make([]byte, n) r.readFull(origName) } else if err != nil { - log.Fatalf("%s: error reading symbol: %v", err) + log.Fatalf("%s: error reading symbol: %v", r.pn, err) } adjName := r.rdBuf[:0] for { |