aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAman Gupta <aman@tmm1.net>2019-04-03 01:49:24 -0700
committerThan McIntosh <thanm@google.com>2019-05-30 12:01:18 +0000
commit2ae793ed48eaef584e3cdcd7820d5bb891ab1a5f (patch)
treecabd0c4c2e5904c3247c3282a3291a20d7991e3a /src
parenta0c96a926122f4437f0eba8ae42cc0369511cb58 (diff)
downloadgo-2ae793ed48eaef584e3cdcd7820d5bb891ab1a5f.tar.xz
cmd/link/internal/ld: ensure mach-o debug symbols are visible to App Store
Passing test that shows Apple's symbols utility can now read DWARF data in go.o, after the fix in CL174538 Updates #31022 #22716 #31459 Change-Id: I56c3517ad6d0a9f39537182f63cef56bb198aa83 Reviewed-on: https://go-review.googlesource.com/c/go/+/170451 Reviewed-by: Than McIntosh <thanm@google.com>
Diffstat (limited to 'src')
-rw-r--r--src/cmd/link/dwarf_test.go2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/cmd/link/dwarf_test.go b/src/cmd/link/dwarf_test.go
index 9c411ff1b8..897b2fc881 100644
--- a/src/cmd/link/dwarf_test.go
+++ b/src/cmd/link/dwarf_test.go
@@ -98,6 +98,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string)
if bytes.HasPrefix(out, []byte("Unable to find file")) {
// This failure will cause the App Store to reject our binaries.
t.Fatalf("symbols %v: failed to parse file", filepath.Base(exe))
+ } else if bytes.Contains(out, []byte(", Empty]")) {
+ t.Fatalf("symbols %v: parsed as empty", filepath.Base(exe))
}
}
}