diff options
| author | Nigel Tao <nigeltao@golang.org> | 2013-02-27 13:05:57 +1100 |
|---|---|---|
| committer | Nigel Tao <nigeltao@golang.org> | 2013-02-27 13:05:57 +1100 |
| commit | 15cce227c78ac2b499e9ad3c49ccb67d2f870169 (patch) | |
| tree | 908d026fcf7fa5663e16e48070e60cfaad7d2f0b /src | |
| parent | 2c2934eeb539a1b137c48b521d15ff3a77bd53a1 (diff) | |
| download | go-15cce227c78ac2b499e9ad3c49ccb67d2f870169.tar.xz | |
exp/cookiejar: add a test for canonicalHost errors.
R=dr.volker.dobler
CC=golang-dev
https://golang.org/cl/7389048
Diffstat (limited to 'src')
| -rw-r--r-- | src/pkg/exp/cookiejar/jar_test.go | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/src/pkg/exp/cookiejar/jar_test.go b/src/pkg/exp/cookiejar/jar_test.go index 286f1c4088..bc17e93603 100644 --- a/src/pkg/exp/cookiejar/jar_test.go +++ b/src/pkg/exp/cookiejar/jar_test.go @@ -51,15 +51,26 @@ var canonicalHostTests = map[string]string{ "[2001:4860:0:::68]:8080": "2001:4860:0:::68", "www.bücher.de": "www.xn--bcher-kva.de", "www.example.com.": "www.example.com", + "[bad.unmatched.bracket:": "error", } func TestCanonicalHost(t *testing.T) { for h, want := range canonicalHostTests { - got, _ := canonicalHost(h) + got, err := canonicalHost(h) + if want == "error" { + if err == nil { + t.Errorf("%q: got nil error, want non-nil", h) + } + continue + } + if err != nil { + t.Errorf("%q: %v", h, err) + continue + } if got != want { t.Errorf("%q: got %q, want %q", h, got, want) + continue } - // TODO handle errors } } |
