diff options
| author | Jes Cok <xigua67damn@gmail.com> | 2023-09-12 22:43:28 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-09-13 00:59:13 +0000 |
| commit | 0460c61e5fd2242d27451f527dafc4d9a098fef4 (patch) | |
| tree | ddc7a3ceb5b05ad91ef9fa71d7f3a1b2367190a7 /src | |
| parent | 4ee1d542eda8d8aab7ca2024a4a0a9068d3cad70 (diff) | |
| download | go-0460c61e5fd2242d27451f527dafc4d9a098fef4.tar.xz | |
go/doc/comment: update TODO for isStdPkg
Even better is slices.BinarySearch, leave a TODO to update to that when possible.
Change-Id: Ie1ec75c34c0329c536725b45e520693790f0520e
GitHub-Last-Rev: 6cd811b186c95752794cead3ae747f54c2d0d0c5
GitHub-Pull-Request: golang/go#62585
Reviewed-on: https://go-review.googlesource.com/c/go/+/527341
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/go/doc/comment/parse.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/go/doc/comment/parse.go b/src/go/doc/comment/parse.go index 62a0f8f2bb..7b60e7ad5b 100644 --- a/src/go/doc/comment/parse.go +++ b/src/go/doc/comment/parse.go @@ -260,8 +260,7 @@ func (d *parseDoc) lookupPkg(pkg string) (importPath string, ok bool) { } func isStdPkg(path string) bool { - // TODO(rsc): Use sort.Find once we don't have to worry about - // copying this code into older Go environments. + // TODO: Use slices.BinarySearch when possible. i := sort.Search(len(stdPkgs), func(i int) bool { return stdPkgs[i] >= path }) return i < len(stdPkgs) && stdPkgs[i] == path } |