diff options
| author | Ariel Mashraki <ariel@mashraki.co.il> | 2019-10-01 18:39:29 +0300 |
|---|---|---|
| committer | Emmanuel Odeke <emm.odeke@gmail.com> | 2019-10-01 19:03:51 +0000 |
| commit | 86cd6c2ee5c5e4c5b5edf4ea8d1c85f80d9706a8 (patch) | |
| tree | d85294a11881143fb36e2978263b9f5088cb5d95 /src/text/template/parse/node.go | |
| parent | 09c9bced825593aedfd79af5c35916392f43113c (diff) | |
| download | go-86cd6c2ee5c5e4c5b5edf4ea8d1c85f80d9706a8.tar.xz | |
text/template/parse: use strings.Builder in Chain and List nodes
This CL is a continuation of 198078. Benchmark output:
benchmark old ns/op new ns/op delta
BenchmarkParseLarge-8 24759165 24516563 -0.98%
BenchmarkVariableString-8 115 115 +0.00%
BenchmarkListString-8 924 680 -26.41%
benchmark old allocs new allocs delta
BenchmarkVariableString-8 3 3 +0.00%
BenchmarkListString-8 14 13 -7.14%
benchmark old bytes new bytes delta
BenchmarkVariableString-8 72 72 +0.00%
BenchmarkListString-8 512 424 -17.19%
Change-Id: I9ec48fe4832437c556a5fa94d4cbf6e29e28d944
Reviewed-on: https://go-review.googlesource.com/c/go/+/198080
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/text/template/parse/node.go')
| -rw-r--r-- | src/text/template/parse/node.go | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/src/text/template/parse/node.go b/src/text/template/parse/node.go index 2eb1af0a95..61c6853679 100644 --- a/src/text/template/parse/node.go +++ b/src/text/template/parse/node.go @@ -7,7 +7,6 @@ package parse import ( - "bytes" "fmt" "strconv" "strings" @@ -94,11 +93,11 @@ func (l *ListNode) tree() *Tree { } func (l *ListNode) String() string { - b := new(bytes.Buffer) + var sb strings.Builder for _, n := range l.Nodes { - fmt.Fprint(b, n) + sb.WriteString(n.String()) } - return b.String() + return sb.String() } func (l *ListNode) CopyList() *ListNode { @@ -472,14 +471,19 @@ func (c *ChainNode) Add(field string) { } func (c *ChainNode) String() string { - s := c.Node.String() + var sb strings.Builder if _, ok := c.Node.(*PipeNode); ok { - s = "(" + s + ")" + sb.WriteByte('(') + sb.WriteString(c.Node.String()) + sb.WriteByte(')') + } else { + sb.WriteString(c.Node.String()) } for _, field := range c.Field { - s += "." + field + sb.WriteByte('.') + sb.WriteString(field) } - return s + return sb.String() } func (c *ChainNode) tree() *Tree { |