diff options
| author | Rob Pike <r@golang.org> | 2019-11-11 10:55:32 +1100 |
|---|---|---|
| committer | Rob Pike <r@golang.org> | 2019-11-12 05:06:42 +0000 |
| commit | b8cb75fb17511538524ac304abe68e62699c4e23 (patch) | |
| tree | a43e7984bd5161b860f0c409069fdc3c1e890573 /src/text/template/exec.go | |
| parent | b60c7a5c7f50fc75ddecb7f1dea6c2e47a12b42c (diff) | |
| download | go-b8cb75fb17511538524ac304abe68e62699c4e23.tar.xz | |
text/template: add error check for parenthesized first argument in pipeline
An error check was missing: If the first argument of a pipeline is
parenthesized, and the pipeline has further arguments, then
syntactically the pipeline is a function invocation and there must
be a "call". Tricky rare corner case, but easily caught.
Add the error check and some tests to verify behavior.
Fixes #31810.
Change-Id: Ica80b7c11284e4ea9e8cc94a01dbbc9a67e42079
Reviewed-on: https://go-review.googlesource.com/c/go/+/206124
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/text/template/exec.go')
| -rw-r--r-- | src/text/template/exec.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/text/template/exec.go b/src/text/template/exec.go index f9bc5d980c..ac3e741390 100644 --- a/src/text/template/exec.go +++ b/src/text/template/exec.go @@ -461,7 +461,8 @@ func (s *state) evalCommand(dot reflect.Value, cmd *parse.CommandNode, final ref // Must be a function. return s.evalFunction(dot, n, cmd, cmd.Args, final) case *parse.PipeNode: - // Parenthesized pipeline. The arguments are all inside the pipeline; final is ignored. + // Parenthesized pipeline. The arguments are all inside the pipeline; final must be absent. + s.notAFunction(cmd.Args, final) return s.evalPipeline(dot, n) case *parse.VariableNode: return s.evalVariableNode(dot, n, cmd.Args, final) |