aboutsummaryrefslogtreecommitdiff
path: root/src/testing/testing_test.go
diff options
context:
space:
mode:
authorMichael Pratt <mpratt@google.com>2023-05-24 12:43:09 -0400
committerGopher Robot <gobot@golang.org>2023-05-24 17:13:42 +0000
commit067dd573b2deba45a02383139bd2885321b2f71d (patch)
tree9c30858a9e118bc5cc24137b19dee4917132a6c0 /src/testing/testing_test.go
parent42f387aae123ec416b57d84ba96ec4a5ef0e8a1b (diff)
downloadgo-067dd573b2deba45a02383139bd2885321b2f71d.tar.xz
cmd/go: fix PGO script flag matching
build_pgo.txt hard-coded a check for / rather than using ${/}, causing a failure on Windows The failure in build_pgo_auto_multi.txt is more interesting. If the first argument to stdout starts with `-` the script engine expects it to be a flag to grep, and thus doesn't regexp-escape `\` in the expansion of `${/}`. The script engine doesn't _require_ that these are flags to grep, so it is still possible to use them for matching, but this ideally will change in the future, so change all patterns to avoid starting with `-`. Fixes #60408. Change-Id: Ie4041a730d22ce40a4436abae7713f211dcb42e4 Reviewed-on: https://go-review.googlesource.com/c/go/+/497881 Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Michael Pratt <mpratt@google.com> Auto-Submit: Michael Pratt <mpratt@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/testing/testing_test.go')
0 files changed, 0 insertions, 0 deletions