diff options
| author | Nick Ripley <nick.ripley@datadoghq.com> | 2025-05-15 07:01:14 -0400 |
|---|---|---|
| committer | Nick Ripley <nick.ripley@datadoghq.com> | 2025-05-15 08:26:27 -0700 |
| commit | 01e0e8b6b397f2e775d9ccbfcde104d025464382 (patch) | |
| tree | 7a7c1b3cb7425e3e0f2da87583e2d7d1c334b18a /src/testing/testing.go | |
| parent | b338f6bfa68da6fc8dfb7a38a975337e659424dc (diff) | |
| download | go-01e0e8b6b397f2e775d9ccbfcde104d025464382.tar.xz | |
runtime/pprof: include PCs for deduplication in TestMutexBlockFullAggregation
TestMutexBlockFullAggregation aggregates stacks by function, file, and
line number. But there can be multiple function calls on the same line,
giving us different sequences of PCs. This causes the test to spuriously
fail in some cases. Include PCs in the stacks for this test.
Also pick up a small "range over int" modernize suggestion while we're
looking at the test.
Fixes #73641
Change-Id: I50489e19fcf920e27b9eebd9d4b35feb89981cbc
Reviewed-on: https://go-review.googlesource.com/c/go/+/673115
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/testing/testing.go')
0 files changed, 0 insertions, 0 deletions