aboutsummaryrefslogtreecommitdiff
path: root/src/syscall/exec_linux.go
diff options
context:
space:
mode:
authorAustin Clements <austin@google.com>2019-06-26 14:35:05 -0400
committerAustin Clements <austin@google.com>2019-06-26 19:48:42 +0000
commit9caaac2c92f866383b52fca544b9871acf5fda1c (patch)
treec8fb0d74fe8cbf1f2d0c05c384f3fe79058a087a /src/syscall/exec_linux.go
parentc19b3a60da360a4e02b18dcb3430ec3485a0a831 (diff)
downloadgo-9caaac2c92f866383b52fca544b9871acf5fda1c.tar.xz
sync: only check for successful PopHeads in long mode
In TestPoolDequeue it's surprisingly common for the queue to stay nearly empty the whole time and for a racing PopTail to happen in the window between the producer doing a PushHead and doing a PopHead. In short mode, there are only 100 PopTail attempts. On linux/amd64, it's not uncommon for this to fail 50% of the time. On linux/arm64, it's not uncommon for this to fail 100% of the time, causing the test to fail. This CL fixes this by only checking for a successful PopTail in long mode. Long mode makes 200,000 PopTail attempts, and has never been observed to fail. Fixes #31422. Change-Id: If464d55eb94fcb0b8d78fbc441d35be9f056a290 Reviewed-on: https://go-review.googlesource.com/c/go/+/183981 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
Diffstat (limited to 'src/syscall/exec_linux.go')
0 files changed, 0 insertions, 0 deletions